Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1176694 > unrolled thread

Re: [PATCH] sched_fair: test list head instead of list entry in throttle_cfs_rq()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] sched_fair: test list head instead of list entry in throttle_cfs_rq() Cong Wang <xiyou.wangcong@gmail.com> - 2015-07-03 18:10 +0200
    Re: [PATCH] sched_fair: test list head instead of list entry in  throttle_cfs_rq() Peter Zijlstra <peterz@infradead.org> - 2015-07-03 18:20 +0200
      Re: [PATCH] sched_fair: test list head instead of list entry in throttle_cfs_rq() Cong Wang <xiyou.wangcong@gmail.com> - 2015-07-03 18:20 +0200

#1176694 — Re: [PATCH] sched_fair: test list head instead of list entry in throttle_cfs_rq()

On Wed, Jun 24, 2015 at 12:41 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
> According to the comments, we need to test if this is
> the first throttled task, however, list_empty() tests on
> the entry cfs_rq->throttled_list, not the head, this is wrong.
>
> This is a bug because we don't re-init the list entry after
> removing it from the list, so list_empty() could return false
> even if the list is really empty.
>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> Signed-off-by: Cong Wang <cwang@twopensource.com>

ping.

What's the status of this patch?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1176698 — Re: [PATCH] sched_fair: test list head instead of list entry in throttle_cfs_rq()

On Fri, Jul 03, 2015 at 09:09:12AM -0700, Cong Wang wrote:
> On Wed, Jun 24, 2015 at 12:41 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
> > According to the comments, we need to test if this is
> > the first throttled task, however, list_empty() tests on
> > the entry cfs_rq->throttled_list, not the head, this is wrong.
> >
> > This is a bug because we don't re-init the list entry after
> > removing it from the list, so list_empty() could return false
> > even if the list is really empty.
> >
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> > Signed-off-by: Cong Wang <cwang@twopensource.com>
> 
> ping.
> 
> What's the status of this patch?

Queued, will likely hit tip after the merge window etc has settled.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1176699

On Fri, Jul 3, 2015 at 9:10 AM, Peter Zijlstra <peterz@infradead.org> wrote:
>
> Queued, will likely hit tip after the merge window etc has settled.

Great.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web