Re: [PATCH] sched_fair: test list head instead of list entry in throttle_cfs_rq()

From	Cong Wang <xiyou.wangcong@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sched_fair: test list head instead of list entry in throttle_cfs_rq()
Date	2015-07-03 18:10 +0200
Message-ID	<pIbHj-2fv-9@gated-at.bofh.it> (permalink)
References	<pEYQi-2EH-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 24, 2015 at 12:41 PM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
> According to the comments, we need to test if this is
> the first throttled task, however, list_empty() tests on
> the entry cfs_rq->throttled_list, not the head, this is wrong.
>
> This is a bug because we don't re-init the list entry after
> removing it from the list, so list_empty() could return false
> even if the list is really empty.
>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> Signed-off-by: Cong Wang <cwang@twopensource.com>

ping.

What's the status of this patch?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] sched_fair: test list head instead of list entry in throttle_cfs_rq() Cong Wang <xiyou.wangcong@gmail.com> - 2015-07-03 18:10 +0200
  Re: [PATCH] sched_fair: test list head instead of list entry in  throttle_cfs_rq() Peter Zijlstra <peterz@infradead.org> - 2015-07-03 18:20 +0200
    Re: [PATCH] sched_fair: test list head instead of list entry in throttle_cfs_rq() Cong Wang <xiyou.wangcong@gmail.com> - 2015-07-03 18:20 +0200

csiph-web