Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1175934 > unrolled thread
| Started by | Felipe Balbi <balbi@ti.com> |
|---|---|
| First post | 2015-07-02 14:30 +0200 |
| Last post | 2015-07-02 15:30 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 2/2] ARM: DTS: am437x-sk-evm: Switch using simple-audio-card for audio support Felipe Balbi <balbi@ti.com> - 2015-07-02 14:30 +0200
Re: [PATCH 2/2] ARM: DTS: am437x-sk-evm: Switch using simple-audio-card for audio support Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-07-02 15:00 +0200
Re: [PATCH 2/2] ARM: DTS: am437x-sk-evm: Switch using simple-audio-card for audio support Felipe Balbi <balbi@ti.com> - 2015-07-02 15:30 +0200
| From | Felipe Balbi <balbi@ti.com> |
|---|---|
| Date | 2015-07-02 14:30 +0200 |
| Subject | Re: [PATCH 2/2] ARM: DTS: am437x-sk-evm: Switch using simple-audio-card for audio support |
| Message-ID | <pHLMS-2Cb-43@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Jul 02, 2015 at 02:58:06PM +0300, Peter Ujfalusi wrote:
> The sound support consist only Headset output on the board and can be
> handled by "simple-audio-card"
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Still works fine:
Tested-by: Felipe Balbi <balbi@ti.com>
one question though, should Line In be listed below ? Also, unrelated to
$subject, but if I wait for a few seconds between runs of speaker-test
(iow, if I allow mcasp to idle) then I hear a slight chopping sound when
starting, perhaps we're unmuting too early ?
> ---
> arch/arm/boot/dts/am437x-sk-evm.dts | 30 ++++++++++++++++++++++--------
> 1 file changed, 22 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts
> index b5de6b0d622c..e09216cb14df 100644
> --- a/arch/arm/boot/dts/am437x-sk-evm.dts
> +++ b/arch/arm/boot/dts/am437x-sk-evm.dts
> @@ -32,14 +32,26 @@
> };
>
> sound {
> - compatible = "ti,da830-evm-audio";
> - ti,model = "AM437x-SK-EVM";
> - ti,audio-codec = <&tlv320aic3106>;
> - ti,mcasp-controller = <&mcasp1>;
> - ti,codec-clock-rate = <24000000>;
> - ti,audio-routing =
> - "Headphone Jack", "HPLOUT",
> - "Headphone Jack", "HPROUT";
> + compatible = "simple-audio-card";
> + simple-audio-card,name = "AM437x-SK-EVM";
> + simple-audio-card,widgets =
> + "Headphone", "Headphone Jack";
> + simple-audio-card,routing =
> + "Headphone Jack", "HPLOUT",
> + "Headphone Jack", "HPROUT";
> + simple-audio-card,format = "dsp_b";
> + simple-audio-card,bitclock-master = <&sound_master>;
> + simple-audio-card,frame-master = <&sound_master>;
> + simple-audio-card,bitclock-inversion;
> +
> + simple-audio-card,cpu {
> + sound-dai = <&mcasp1>;
> + };
> +
> + sound_master: simple-audio-card,codec {
> + sound-dai = <&tlv320aic3106>;
> + system-clock-frequency = <24000000>;
> + };
> };
>
> matrix_keypad: matrix_keypad@0 {
> @@ -489,6 +501,7 @@
> };
>
> tlv320aic3106: tlv320aic3106@1b {
> + #sound-dai-cells = <0>;
> compatible = "ti,tlv320aic3106";
> reg = <0x1b>;
> status = "okay";
> @@ -649,6 +662,7 @@
> };
>
> &mcasp1 {
> + #sound-dai-cells = <0>;
> pinctrl-names = "default", "sleep";
> pinctrl-0 = <&mcasp1_pins>;
> pinctrl-1 = <&mcasp1_pins_sleep>;
> --
> 2.4.5
>
--
balbi
[toc] | [next] | [standalone]
| From | Peter Ujfalusi <peter.ujfalusi@ti.com> |
|---|---|
| Date | 2015-07-02 15:00 +0200 |
| Message-ID | <pHMfU-2Nx-1@gated-at.bofh.it> |
| In reply to | #1175934 |
On 07/02/2015 03:23 PM, Felipe Balbi wrote:
> On Thu, Jul 02, 2015 at 02:58:06PM +0300, Peter Ujfalusi wrote:
>> The sound support consist only Headset output on the board and can be
>> handled by "simple-audio-card"
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Still works fine:
>
> Tested-by: Felipe Balbi <balbi@ti.com>
>
> one question though, should Line In be listed below ?
Does the board have Line-in? I don't have the board, but I know this patch
works on it ;)
We only had playback path before also.
> Also, unrelated to
> $subject, but if I wait for a few seconds between runs of speaker-test
> (iow, if I allow mcasp to idle) then I hear a slight chopping sound when
> starting, perhaps we're unmuting too early ?
Is it only with this patch (via simple-card) or was it the same via the
davinci-evm (ti,da830-evm-audio)?
--
Péter
>
>> ---
>> arch/arm/boot/dts/am437x-sk-evm.dts | 30 ++++++++++++++++++++++--------
>> 1 file changed, 22 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts
>> index b5de6b0d622c..e09216cb14df 100644
>> --- a/arch/arm/boot/dts/am437x-sk-evm.dts
>> +++ b/arch/arm/boot/dts/am437x-sk-evm.dts
>> @@ -32,14 +32,26 @@
>> };
>>
>> sound {
>> - compatible = "ti,da830-evm-audio";
>> - ti,model = "AM437x-SK-EVM";
>> - ti,audio-codec = <&tlv320aic3106>;
>> - ti,mcasp-controller = <&mcasp1>;
>> - ti,codec-clock-rate = <24000000>;
>> - ti,audio-routing =
>> - "Headphone Jack", "HPLOUT",
>> - "Headphone Jack", "HPROUT";
>> + compatible = "simple-audio-card";
>> + simple-audio-card,name = "AM437x-SK-EVM";
>> + simple-audio-card,widgets =
>> + "Headphone", "Headphone Jack";
>> + simple-audio-card,routing =
>> + "Headphone Jack", "HPLOUT",
>> + "Headphone Jack", "HPROUT";
>> + simple-audio-card,format = "dsp_b";
>> + simple-audio-card,bitclock-master = <&sound_master>;
>> + simple-audio-card,frame-master = <&sound_master>;
>> + simple-audio-card,bitclock-inversion;
>> +
>> + simple-audio-card,cpu {
>> + sound-dai = <&mcasp1>;
>> + };
>> +
>> + sound_master: simple-audio-card,codec {
>> + sound-dai = <&tlv320aic3106>;
>> + system-clock-frequency = <24000000>;
>> + };
>> };
>>
>> matrix_keypad: matrix_keypad@0 {
>> @@ -489,6 +501,7 @@
>> };
>>
>> tlv320aic3106: tlv320aic3106@1b {
>> + #sound-dai-cells = <0>;
>> compatible = "ti,tlv320aic3106";
>> reg = <0x1b>;
>> status = "okay";
>> @@ -649,6 +662,7 @@
>> };
>>
>> &mcasp1 {
>> + #sound-dai-cells = <0>;
>> pinctrl-names = "default", "sleep";
>> pinctrl-0 = <&mcasp1_pins>;
>> pinctrl-1 = <&mcasp1_pins_sleep>;
>> --
>> 2.4.5
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Felipe Balbi <balbi@ti.com> |
|---|---|
| Date | 2015-07-02 15:30 +0200 |
| Message-ID | <pHMIV-3df-1@gated-at.bofh.it> |
| In reply to | #1175950 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Jul 02, 2015 at 03:52:49PM +0300, Peter Ujfalusi wrote: > On 07/02/2015 03:23 PM, Felipe Balbi wrote: > > On Thu, Jul 02, 2015 at 02:58:06PM +0300, Peter Ujfalusi wrote: > >> The sound support consist only Headset output on the board and can be > >> handled by "simple-audio-card" > >> > >> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > > > > Still works fine: > > > > Tested-by: Felipe Balbi <balbi@ti.com> > > > > one question though, should Line In be listed below ? > > Does the board have Line-in? I don't have the board, but I know this patch yeah, it does :-) > works on it ;) > We only had playback path before also. indeed, should go for -next only :-s > > Also, unrelated to > > $subject, but if I wait for a few seconds between runs of speaker-test > > (iow, if I allow mcasp to idle) then I hear a slight chopping sound when > > starting, perhaps we're unmuting too early ? > > Is it only with this patch (via simple-card) or was it the same via the > davinci-evm (ti,da830-evm-audio)? /me goes test again also without this patch :-) -- balbi
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web