Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1175622 > unrolled thread
| Started by | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| First post | 2015-07-02 02:10 +0200 |
| Last post | 2015-07-02 02:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v5 2/3] ARM: dts: Add CPU OPP and regulator supply property for Exynos3250 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-02 02:10 +0200
Re: [PATCH v5 2/3] ARM: dts: Add CPU OPP and regulator supply property for Exynos3250 Chanwoo Choi <cw00.choi@samsung.com> - 2015-07-02 02:40 +0200
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2015-07-02 02:10 +0200 |
| Subject | Re: [PATCH v5 2/3] ARM: dts: Add CPU OPP and regulator supply property for Exynos3250 |
| Message-ID | <pHAeJ-3Ll-9@gated-at.bofh.it> |
On 01.07.2015 22:21, Chanwoo Choi wrote:
> This patch add CPU operating points which include CPU frequency and regulator
> voltage to use generic cpufreq drivers.
>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/boot/dts/exynos3250-monk.dts | 4 ++++
> arch/arm/boot/dts/exynos3250-rinato.dts | 4 ++++
> arch/arm/boot/dts/exynos3250.dtsi | 15 +++++++++++++++
> 3 files changed, 23 insertions(+)
The patch looks good. Could you put the 'cpu' nodes in alphabetical
order? The order for Rinato board is already broken but still putting it
after 'adc' node would be better.
With the change above:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
>
> diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts
> index a5863acc5fff..fc6604d68864 100644
> --- a/arch/arm/boot/dts/exynos3250-monk.dts
> +++ b/arch/arm/boot/dts/exynos3250-monk.dts
> @@ -118,6 +118,10 @@
> };
> };
>
> +&cpu0 {
> + cpu0-supply = <&buck2_reg>;
> +};
> +
> &adc {
> vdd-supply = <&ldo3_reg>;
> status = "okay";
> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
> index 031853b75528..c8a083b376c9 100644
> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
> @@ -109,6 +109,10 @@
> };
> };
>
> +&cpu0 {
> + cpu0-supply = <&buck2_reg>;
> +};
> +
> &adc {
> vdd-supply = <&ldo3_reg>;
> status = "okay";
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
> index d7201333e3bc..e0f3b2ed41a3 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -53,6 +53,21 @@
> compatible = "arm,cortex-a7";
> reg = <0>;
> clock-frequency = <1000000000>;
> + clocks = <&cmu CLK_ARM_CLK>;
> + clock-names = "cpu";
> +
> + operating-points = <
> + 1000000 1150000
> + 900000 1112500
> + 800000 1075000
> + 700000 1037500
> + 600000 1000000
> + 500000 962500
> + 400000 925000
> + 300000 887500
> + 200000 850000
> + 100000 850000
> + >;
> };
>
> cpu1: cpu@1 {
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Date | 2015-07-02 02:40 +0200 |
| Message-ID | <pHAHL-3UX-13@gated-at.bofh.it> |
| In reply to | #1175622 |
On 07/02/2015 09:01 AM, Krzysztof Kozlowski wrote: > On 01.07.2015 22:21, Chanwoo Choi wrote: >> This patch add CPU operating points which include CPU frequency and regulator >> voltage to use generic cpufreq drivers. >> >> Cc: Kukjin Kim <kgene@kernel.org> >> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> >> --- >> arch/arm/boot/dts/exynos3250-monk.dts | 4 ++++ >> arch/arm/boot/dts/exynos3250-rinato.dts | 4 ++++ >> arch/arm/boot/dts/exynos3250.dtsi | 15 +++++++++++++++ >> 3 files changed, 23 insertions(+) > > The patch looks good. Could you put the 'cpu' nodes in alphabetical > order? The order for Rinato board is already broken but still putting it > after 'adc' node would be better. > > With the change above: > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> OK. I'll resend it. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web