Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1175628

Re: [PATCH v5 2/3] ARM: dts: Add CPU OPP and regulator supply property for Exynos3250

Show all headers | View raw

On 07/02/2015 09:01 AM, Krzysztof Kozlowski wrote:
> On 01.07.2015 22:21, Chanwoo Choi wrote:
>> This patch add CPU operating points which include CPU frequency and regulator
>> voltage to use generic cpufreq drivers.
>>
>> Cc: Kukjin Kim <kgene@kernel.org>
>> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
>> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>>  arch/arm/boot/dts/exynos3250-monk.dts   |  4 ++++
>>  arch/arm/boot/dts/exynos3250-rinato.dts |  4 ++++
>>  arch/arm/boot/dts/exynos3250.dtsi       | 15 +++++++++++++++
>>  3 files changed, 23 insertions(+)
> 
> The patch looks good. Could you put the 'cpu' nodes in alphabetical
> order? The order for Rinato board is already broken but still putting it
> after 'adc' node would be better.
> 
> With the change above:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

OK. I'll resend it.

Thanks,
Chanwoo Choi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 2/3] ARM: dts: Add CPU OPP and regulator supply property  for Exynos3250 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-02 02:10 +0200
  Re: [PATCH v5 2/3] ARM: dts: Add CPU OPP and regulator supply property  for Exynos3250 Chanwoo Choi <cw00.choi@samsung.com> - 2015-07-02 02:40 +0200

csiph-web