Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1173409 > unrolled thread
| Started by | Toralf Förster <toralf.foerster@gmx.de> |
|---|---|
| First post | 2015-06-27 21:20 +0200 |
| Last post | 2015-06-27 21:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
Re: [PATCH] x86: fix -Wsign-compare warnings in uaccess.h Toralf Förster <toralf.foerster@gmx.de> - 2015-06-27 21:20 +0200
Re: [PATCH] x86: fix -Wsign-compare warnings in uaccess.h Роман Донченко <dpb@corrigendum.ru> - 2015-06-27 21:30 +0200
| From | Toralf Förster <toralf.foerster@gmx.de> |
|---|---|
| Date | 2015-06-27 21:20 +0200 |
| Subject | Re: [PATCH] x86: fix -Wsign-compare warnings in uaccess.h |
| Message-ID | <pG3NU-6vb-15@gated-at.bofh.it> |
>The casts are safe, since those conditions are only evaluated when sz >= 0. Wouldn't in this case the condition "sz < 0" be superfluously ? -- Toralf pgp key: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 0076 E94E -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Роман Донченко <dpb@corrigendum.ru> |
|---|---|
| Date | 2015-06-27 21:30 +0200 |
| Message-ID | <pG3XA-6Gx-9@gated-at.bofh.it> |
| In reply to | #1173409 |
Toralf Förster <toralf.foerster@gmx.de> писал в своём письме Sat, 27 Jun 2015 22:16:27 +0300: >> The casts are safe, since those conditions are only evaluated when sz >> >= 0. > > > Wouldn't in this case the condition "sz < 0" be superfluously ? No, sz can be negative. I meant that if sz < 0, then the second halves won't be evaluated (though even if they did, it wouldn't matter). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web