Re: [PATCH] x86: fix -Wsign-compare warnings in uaccess.h

From	Роман Донченко <dpb@corrigendum.ru>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86: fix -Wsign-compare warnings in uaccess.h
Date	2015-06-27 21:30 +0200
Message-ID	<pG3XA-6Gx-9@gated-at.bofh.it> (permalink)
References	<pG3NU-6vb-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Toralf Förster <toralf.foerster@gmx.de> писал в своём письме Sat, 27 Jun  
2015 22:16:27 +0300:

>> The casts are safe, since those conditions are only evaluated when sz  
>> >= 0.
>
>
> Wouldn't in this case the condition "sz < 0" be superfluously ?

No, sz can be negative. I meant that if sz < 0, then the second halves  
won't be evaluated (though even if they did, it wouldn't matter).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] x86: fix -Wsign-compare warnings in uaccess.h Toralf Förster <toralf.foerster@gmx.de> - 2015-06-27 21:20 +0200
  Re: [PATCH] x86: fix -Wsign-compare warnings in uaccess.h Роман Донченко   <dpb@corrigendum.ru> - 2015-06-27 21:30 +0200

csiph-web