Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1171853 > unrolled thread

Re: [PATCH V2 1/1] usb:serial:f81534 Add F81532/534 Driver

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH V2 1/1] usb:serial:f81534 Add F81532/534 Driver Peter Hung <hpeter@gmail.com> - 2015-06-25 07:20 +0200
    Re: [PATCH V2 1/1] usb:serial:f81534 Add F81532/534 Driver Peter Hung <hpeter@gmail.com> - 2015-06-25 11:30 +0200
      Re: [PATCH V2 1/1] usb:serial:f81534 Add F81532/534 Driver Johan Hovold <johan@kernel.org> - 2015-06-25 11:30 +0200

#1171853 — Re: [PATCH V2 1/1] usb:serial:f81534 Add F81532/534 Driver

Hello Johan,

Peter Hung 於 2015/6/15 上午 09:54 寫道:
> This driver is for Fintek F81532/F81534 USB to Serial Ports IC.
> 
> Features:
> 1. F81534 is 1-to-4 & F81532 is 1-to-2 serial ports IC
> 2. Support Baudrate from B50 to B1500000 (excluding B1000000).
> 3. The RTS signal can be transformed their behavior with configuration
>     for transceiver (for RS232/RS485/RS422) (/sys/class/ttyUSBx/uart_mode)
> 4. There are 4x3 output-only GPIOs to control transceiver mode. It's
>     can be controlled via sysfs (/sys/class/ttyUSBx/gpio)
> 

Do you receive my patch?
Are there anything should I do to improve it ?

-- 
With Best Regards,
Peter Hung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1171968

Hi Johan,

Johan Hovold 於 2015/6/25 下午 04:06 寫道:
>   - As Greg already mentioned, you need to implement gpio support using
>     gpiolib, not a custom sysfs interface
>
> I don't have time to look closer at the architectural bits until next
> week I'm afraid, but perhaps you could start with the above.

Thanks for your advices, I'll try to improve it again.
But I had something need to clarify.

1. The sysfs interface of the driver provide "limited output pin"
    control. only support output 0/1, not support input mode.
    Should I implement it as gpiolib?

2. If it still recommends to implement with gpiolib, Could I implement
    it and preserve the sysfs interface for legacy?

-- 
With Best Regards,
Peter Hung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1171969

On Thu, Jun 25, 2015 at 05:21:01PM +0800, Peter Hung wrote:
> Hi Johan,
> 
> Johan Hovold 於 2015/6/25 下午 04:06 寫道:
> >   - As Greg already mentioned, you need to implement gpio support using
> >     gpiolib, not a custom sysfs interface
> >
> > I don't have time to look closer at the architectural bits until next
> > week I'm afraid, but perhaps you could start with the above.
> 
> Thanks for your advices, I'll try to improve it again.
> But I had something need to clarify.
> 
> 1. The sysfs interface of the driver provide "limited output pin"
>     control. only support output 0/1, not support input mode.
>     Should I implement it as gpiolib?

Yes.

> 2. If it still recommends to implement with gpiolib, Could I implement
>     it and preserve the sysfs interface for legacy?

No, I'm afraid not. We don't want to have to maintain out-of-tree legacy
interfaces.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web