Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1171969

Re: [PATCH V2 1/1] usb:serial:f81534 Add F81532/534 Driver

Show all headers | View raw

On Thu, Jun 25, 2015 at 05:21:01PM +0800, Peter Hung wrote:
> Hi Johan,
> 
> Johan Hovold 於 2015/6/25 下午 04:06 寫道:
> >   - As Greg already mentioned, you need to implement gpio support using
> >     gpiolib, not a custom sysfs interface
> >
> > I don't have time to look closer at the architectural bits until next
> > week I'm afraid, but perhaps you could start with the above.
> 
> Thanks for your advices, I'll try to improve it again.
> But I had something need to clarify.
> 
> 1. The sysfs interface of the driver provide "limited output pin"
>     control. only support output 0/1, not support input mode.
>     Should I implement it as gpiolib?

Yes.

> 2. If it still recommends to implement with gpiolib, Could I implement
>     it and preserve the sysfs interface for legacy?

No, I'm afraid not. We don't want to have to maintain out-of-tree legacy
interfaces.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V2 1/1] usb:serial:f81534 Add F81532/534 Driver Peter Hung <hpeter@gmail.com> - 2015-06-25 07:20 +0200
  Re: [PATCH V2 1/1] usb:serial:f81534 Add F81532/534 Driver Peter Hung <hpeter@gmail.com> - 2015-06-25 11:30 +0200
    Re: [PATCH V2 1/1] usb:serial:f81534 Add F81532/534 Driver Johan Hovold <johan@kernel.org> - 2015-06-25 11:30 +0200

csiph-web