Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1169843 > unrolled thread

Re: [PATCH 1/4] mfd: da9150: Add support for Fuel-Gauge

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/4] mfd: da9150: Add support for Fuel-Gauge Lee Jones <lee.jones@linaro.org> - 2015-06-22 13:20 +0200
    RE: [PATCH 1/4] mfd: da9150: Add support for Fuel-Gauge "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com> - 2015-06-25 11:40 +0200

#1169843 — Re: [PATCH 1/4] mfd: da9150: Add support for Fuel-Gauge

On Mon, 22 Jun 2015, Opensource [Adam Thomson] wrote:

> On June 19, 2015 17:48, Paul Bolle wrote:
> 
> > On Thu, 2015-06-18 at 17:06 +0100, Adam Thomson wrote:
> > > --- /dev/null
> > > +++ b/include/linux/mfd/da9150/fg.h
> > 
> > > +/*
> > > + * Function template to provide battery temperature. Should provide
> > > + * 0.1 degrees C resolution return values.
> > > + */
> > > +typedef int (*da9150_read_temp_t)(void *context);
> > > +
> > > +/* Register temp callback function */
> > > +void da9150_fg_register_temp_cb(struct power_supply *psy,
> > da9150_read_temp_t cb,
> > > +				void *cb_context);
> > 
> > The pedant in me noticed that this function is actually added in 3/4. So
> > this chunk might be moved to 3/4, if you like to entertain pedantry like
> > that, that is. (But see my remark on 3/4 too.)
> 
> This is true, but as the header is part of MFD, I included it as part of that
> patch as I thought this made more sense. I guess Lee will comment as to whether
> that was correct or not. :)

Glanced over this (as I still have 240 unread emails to attend to).
If the question is whether to submit the prototype at the same time as
the associated function, the answer is yes.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1171974

T24gSnVuZSAyMiwgMjAxNSAxNzo0OCwgTGVlIEpvbmVzIHdyb3RlOg0KDQo+ID4gPiBUaGUgcGVk
YW50IGluIG1lIG5vdGljZWQgdGhhdCB0aGlzIGZ1bmN0aW9uIGlzIGFjdHVhbGx5IGFkZGVkIGlu
IDMvNC4gU28NCj4gPiA+IHRoaXMgY2h1bmsgbWlnaHQgYmUgbW92ZWQgdG8gMy80LCBpZiB5b3Ug
bGlrZSB0byBlbnRlcnRhaW4gcGVkYW50cnkgbGlrZQ0KPiA+ID4gdGhhdCwgdGhhdCBpcy4gKEJ1
dCBzZWUgbXkgcmVtYXJrIG9uIDMvNCB0b28uKQ0KPiA+DQo+ID4gVGhpcyBpcyB0cnVlLCBidXQg
YXMgdGhlIGhlYWRlciBpcyBwYXJ0IG9mIE1GRCwgSSBpbmNsdWRlZCBpdCBhcyBwYXJ0IG9mIHRo
YXQNCj4gPiBwYXRjaCBhcyBJIHRob3VnaHQgdGhpcyBtYWRlIG1vcmUgc2Vuc2UuIEkgZ3Vlc3Mg
TGVlIHdpbGwgY29tbWVudCBhcyB0byB3aGV0aGVyDQo+ID4gdGhhdCB3YXMgY29ycmVjdCBvciBu
b3QuIDopDQo+IA0KPiBHbGFuY2VkIG92ZXIgdGhpcyAoYXMgSSBzdGlsbCBoYXZlIDI0MCB1bnJl
YWQgZW1haWxzIHRvIGF0dGVuZCB0bykuDQo+IElmIHRoZSBxdWVzdGlvbiBpcyB3aGV0aGVyIHRv
IHN1Ym1pdCB0aGUgcHJvdG90eXBlIGF0IHRoZSBzYW1lIHRpbWUgYXMNCj4gdGhlIGFzc29jaWF0
ZWQgZnVuY3Rpb24sIHRoZSBhbnN3ZXIgaXMgeWVzLg0KDQpIb3BlIHlvdSd2ZSBtYW5hZ2VkIHRv
IHRyYXdsIHRocm91Z2ggdGhlIGUtbWFpbHMuDQoNClRoZSBxdWVzdGlvbiB3YXMgd2hldGhlciBv
ciBub3QgdGhlIGZ1bmN0aW9uIGFuZCBwcm90b3R5cGUgc2hvdWxkIGJlIHN1Ym1pdHRlZA0KYXMg
cGFydCBvZiB0aGUgc2FtZSBpbmRpdmlkdWFsIHBhdGNoIGZpbGUuIEJvdGggYXJlIHN1Ym1pdHRl
ZCBhcyBwYXJ0IG9mIHRoZQ0KcGF0Y2ggc2V0IGJ1dCB0aGUgcHJvdG90eXBlIHJlc2lkZXMgaW4g
dGhlIE1GRCBwYXRjaCwgYW5kIHRoZSBmdW5jdGlvbiBpbiB0aGUNCnBvd2VyIChmdWVsLWdhdWdl
KSBwYXRjaC4gUGVyc29uYWxseSwgdGhpcyBzZWVtcyBmaW5lIHRvIG1lIGJ1dCBJJ20gbm90IGEN
Cm1haW50YWluZXIuDQo=
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web