Re: [PATCH 1/4] mfd: da9150: Add support for Fuel-Gauge

From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/4] mfd: da9150: Add support for Fuel-Gauge
Date	2015-06-22 13:20 +0200
Message-ID	<pE7VE-22X-13@gated-at.bofh.it> (permalink)
References	<pCKHM-59O-5@gated-at.bofh.it> <pCKHM-59O-11@gated-at.bofh.it> <pD7El-4Bs-5@gated-at.bofh.it> <pE79f-Te-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 22 Jun 2015, Opensource [Adam Thomson] wrote:

> On June 19, 2015 17:48, Paul Bolle wrote:
> 
> > On Thu, 2015-06-18 at 17:06 +0100, Adam Thomson wrote:
> > > --- /dev/null
> > > +++ b/include/linux/mfd/da9150/fg.h
> > 
> > > +/*
> > > + * Function template to provide battery temperature. Should provide
> > > + * 0.1 degrees C resolution return values.
> > > + */
> > > +typedef int (*da9150_read_temp_t)(void *context);
> > > +
> > > +/* Register temp callback function */
> > > +void da9150_fg_register_temp_cb(struct power_supply *psy,
> > da9150_read_temp_t cb,
> > > +				void *cb_context);
> > 
> > The pedant in me noticed that this function is actually added in 3/4. So
> > this chunk might be moved to 3/4, if you like to entertain pedantry like
> > that, that is. (But see my remark on 3/4 too.)
> 
> This is true, but as the header is part of MFD, I included it as part of that
> patch as I thought this made more sense. I guess Lee will comment as to whether
> that was correct or not. :)

Glanced over this (as I still have 240 unread emails to attend to).
If the question is whether to submit the prototype at the same time as
the associated function, the answer is yes.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/4] mfd: da9150: Add support for Fuel-Gauge Lee Jones <lee.jones@linaro.org> - 2015-06-22 13:20 +0200
  RE: [PATCH 1/4] mfd: da9150: Add support for Fuel-Gauge "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com> - 2015-06-25 11:40 +0200

csiph-web