Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1169380 > unrolled thread

Re: [PATCH v3 08/18] baycom_epp: Replace rdtscl() with native_read_tsc()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3 08/18] baycom_epp: Replace rdtscl() with  native_read_tsc() Thomas Gleixner <tglx@linutronix.de> - 2015-06-20 18:40 +0200

#1169380 — Re: [PATCH v3 08/18] baycom_epp: Replace rdtscl() with native_read_tsc()

On Sat, 20 Jun 2015, Andy Lutomirski wrote:
> On Sat, Jun 20, 2015 at 7:14 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Sat, 20 Jun 2015, walter harms wrote:
> >
> >> Acked-by: walter harms <wharms@bfs.de>
> >>
> >> Am 17.06.2015 02:35, schrieb Andy Lutomirski:
> >> > This is only used if BAYCOM_DEBUG is defined.
> >
> > So why don't we just replace that by ktime_get() and get rid of the
> > x86'ism in that driver.
> >
> 
> I don't have the hardware, and I don't see any good reason to make an
> rdtsc cleanup depend on a more complicated driver change.  On the
> other hand, if the maintainers want to clean it up, I think it would
> be a great idea.
> 
> This really seems to be debugging code, though.  A normal kernel won't
> even compile it.

Right, but there is no reason that we have rdtsc outside of arch/x86
at all.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web