Re: [PATCH v3 08/18] baycom_epp: Replace rdtscl() with native_read_tsc()

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 08/18] baycom_epp: Replace rdtscl() with native_read_tsc()
Date	2015-06-20 18:40 +0200
Message-ID	<pDtYe-3hG-9@gated-at.bofh.it> (permalink)
References	<pC9yx-1Vr-3@gated-at.bofh.it> <pC9Ie-26Q-11@gated-at.bofh.it> <pDrto-85O-3@gated-at.bofh.it> <pDrMK-fJ-1@gated-at.bofh.it> <pDrWq-r3-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 20 Jun 2015, Andy Lutomirski wrote:
> On Sat, Jun 20, 2015 at 7:14 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Sat, 20 Jun 2015, walter harms wrote:
> >
> >> Acked-by: walter harms <wharms@bfs.de>
> >>
> >> Am 17.06.2015 02:35, schrieb Andy Lutomirski:
> >> > This is only used if BAYCOM_DEBUG is defined.
> >
> > So why don't we just replace that by ktime_get() and get rid of the
> > x86'ism in that driver.
> >
> 
> I don't have the hardware, and I don't see any good reason to make an
> rdtsc cleanup depend on a more complicated driver change.  On the
> other hand, if the maintainers want to clean it up, I think it would
> be a great idea.
> 
> This really seems to be debugging code, though.  A normal kernel won't
> even compile it.

Right, but there is no reason that we have rdtsc outside of arch/x86
at all.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v3 08/18] baycom_epp: Replace rdtscl() with  native_read_tsc() Thomas Gleixner <tglx@linutronix.de> - 2015-06-20 18:40 +0200

csiph-web