Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1168597 > unrolled thread

Re: [PATCH] staging: media: lirc: fix coding style error

Started byDan Carpenter <dan.carpenter@oracle.com>
First post2015-06-19 10:10 +0200
Last post2015-06-19 16:10 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] staging: media: lirc: fix coding style error Dan Carpenter <dan.carpenter@oracle.com> - 2015-06-19 10:10 +0200
    [PATCH] staging: media: lirc: fix coding style error Sunil Shahu <shshahu@gmail.com> - 2015-06-19 10:50 +0200
    [PATCH] staging: media: lirc: fix coding style error Sunil Shahu <shshahu@gmail.com> - 2015-06-19 11:00 +0200
      Re: [PATCH] staging: media: lirc: fix coding style error Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-06-19 16:10 +0200

#1168597 — Re: [PATCH] staging: media: lirc: fix coding style error

FromDan Carpenter <dan.carpenter@oracle.com>
Date2015-06-19 10:10 +0200
SubjectRe: [PATCH] staging: media: lirc: fix coding style error
Message-ID<pCZx8-1y4-15@gated-at.bofh.it>
On Wed, Jun 17, 2015 at 06:01:32PM +0530, Sunil Shahu wrote:
> Fix code indentation error by replacing tab in place of spaces.
> 
> Signed-off-by: Sunil Shahu <shshahu@gmail.com>
> ---
>  drivers/staging/media/lirc/lirc_sasem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/media/lirc/lirc_sasem.c
> index 8ebee96..12aae72 100644
> --- a/drivers/staging/media/lirc/lirc_sasem.c
> +++ b/drivers/staging/media/lirc/lirc_sasem.c
> @@ -185,7 +185,7 @@ static void deregister_from_lirc(struct sasem_context *context)
>  		       __func__, retval);
>  	else
>  		dev_info(&context->dev->dev,
> -		         "Deregistered Sasem driver (minor:%d)\n", minor);
> +			"Deregistered Sasem driver (minor:%d)\n", minor);

Not quite.  The original is:

[tab][tab][space][space][space][space][space][space][space][space][space]"Dere...

You have:

[tab][tab][tab]"Deregistered Sasem driver ...

It should be:

[tab][tab][tab][space]"Deregistered Sasem driver (minor:%d)\n", minor);

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1168623

FromSunil Shahu <shshahu@gmail.com>
Date2015-06-19 10:50 +0200
Message-ID<pD09Q-2hv-13@gated-at.bofh.it>
In reply to#1168597
Fix code indentation error by replacing tab in place of spaces.

Signed-off-by: Sunil Shahu <shshahu@gmail.com>
---
 drivers/staging/media/lirc/lirc_sasem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/media/lirc/lirc_sasem.c
index 8ebee96..12aae72 100644
--- a/drivers/staging/media/lirc/lirc_sasem.c
+++ b/drivers/staging/media/lirc/lirc_sasem.c
@@ -185,7 +185,7 @@ static void deregister_from_lirc(struct sasem_context *context)
 		       __func__, retval);
 	else
 		dev_info(&context->dev->dev,
-		         "Deregistered Sasem driver (minor:%d)\n", minor);
+			"Deregistered Sasem driver (minor:%d)\n", minor);
 
 }
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1168640

FromSunil Shahu <shshahu@gmail.com>
Date2015-06-19 11:00 +0200
Message-ID<pD0jx-2sP-19@gated-at.bofh.it>
In reply to#1168597
Fix code indentation error by replacing tab in place of spaces.

Signed-off-by: Sunil Shahu <shshahu@gmail.com>
---
 drivers/staging/media/lirc/lirc_sasem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/media/lirc/lirc_sasem.c
index 8ebee96..c14ca7e 100644
--- a/drivers/staging/media/lirc/lirc_sasem.c
+++ b/drivers/staging/media/lirc/lirc_sasem.c
@@ -185,7 +185,7 @@ static void deregister_from_lirc(struct sasem_context *context)
 		       __func__, retval);
 	else
 		dev_info(&context->dev->dev,
-		         "Deregistered Sasem driver (minor:%d)\n", minor);
+			 "Deregistered Sasem driver (minor:%d)\n", minor);
 
 }
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1168795

FromSudip Mukherjee <sudipm.mukherjee@gmail.com>
Date2015-06-19 16:10 +0200
Message-ID<pD59w-1ao-1@gated-at.bofh.it>
In reply to#1168640
On Fri, Jun 19, 2015 at 02:22:02PM +0530, Sunil Shahu wrote:
> Fix code indentation error by replacing tab in place of spaces.
> 
> Signed-off-by: Sunil Shahu <shshahu@gmail.com>
when you are sending a modified patch, please mark it as [PATCH v2]
otherwise it becomes confusing.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web