Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1168597

Re: [PATCH] staging: media: lirc: fix coding style error

From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH] staging: media: lirc: fix coding style error
Date 2015-06-19 10:10 +0200
Message-ID <pCZx8-1y4-15@gated-at.bofh.it> (permalink)
References <pCkNk-1rX-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Jun 17, 2015 at 06:01:32PM +0530, Sunil Shahu wrote:
> Fix code indentation error by replacing tab in place of spaces.
> 
> Signed-off-by: Sunil Shahu <shshahu@gmail.com>
> ---
>  drivers/staging/media/lirc/lirc_sasem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/media/lirc/lirc_sasem.c
> index 8ebee96..12aae72 100644
> --- a/drivers/staging/media/lirc/lirc_sasem.c
> +++ b/drivers/staging/media/lirc/lirc_sasem.c
> @@ -185,7 +185,7 @@ static void deregister_from_lirc(struct sasem_context *context)
>  		       __func__, retval);
>  	else
>  		dev_info(&context->dev->dev,
> -		         "Deregistered Sasem driver (minor:%d)\n", minor);
> +			"Deregistered Sasem driver (minor:%d)\n", minor);

Not quite.  The original is:

[tab][tab][space][space][space][space][space][space][space][space][space]"Dere...

You have:

[tab][tab][tab]"Deregistered Sasem driver ...

It should be:

[tab][tab][tab][space]"Deregistered Sasem driver (minor:%d)\n", minor);

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] staging: media: lirc: fix coding style error Dan Carpenter <dan.carpenter@oracle.com> - 2015-06-19 10:10 +0200
  [PATCH] staging: media: lirc: fix coding style error Sunil Shahu <shshahu@gmail.com> - 2015-06-19 10:50 +0200
  [PATCH] staging: media: lirc: fix coding style error Sunil Shahu <shshahu@gmail.com> - 2015-06-19 11:00 +0200
    Re: [PATCH] staging: media: lirc: fix coding style error Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-06-19 16:10 +0200

csiph-web