Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1166317 > unrolled thread
| Started by | Luke Skywalker <lukes357@gmail.com> |
|---|---|
| First post | 2015-06-16 21:00 +0200 |
| Last post | 2015-06-16 21:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] small update for strlen, strnlen, use less cpu instructions Luke Skywalker <lukes357@gmail.com> - 2015-06-16 21:00 +0200
Re: [PATCH] small update for strlen, strnlen, use less cpu instructions Darth Vader <bp@alien8.de> - 2015-06-16 21:10 +0200
| From | Luke Skywalker <lukes357@gmail.com> |
|---|---|
| Date | 2015-06-16 21:00 +0200 |
| Subject | Re: [PATCH] small update for strlen, strnlen, use less cpu instructions |
| Message-ID | <pC4fv-2B3-1@gated-at.bofh.it> |
> This is not a valid patch submission. Please see > Documentation/SubmittingPatches. I resent the patch an hour ago based on that document, thanks for pointing this out. I need to know if the patch is in good shape now, thanks > > Anyway, why do you think your patch makes strlen() better? > Now strlen() increments a variable for each character it faces, hence > it will consume more cycles. you can look at the output of objdump -d to see why, also the assembly snippet send by another person make this clear. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Darth Vader <bp@alien8.de> |
|---|---|
| Date | 2015-06-16 21:10 +0200 |
| Subject | Re: [PATCH] small update for strlen, strnlen, use less cpu instructions |
| Message-ID | <pC4pc-32i-13@gated-at.bofh.it> |
| In reply to | #1166317 |
Luke, On Tue, Jun 16, 2015 at 01:56:52PM -0500, Luke Skywalker wrote: > > This is not a valid patch submission. Please see > > Documentation/SubmittingPatches. > > I resent the patch an hour ago based on that document, thanks for > pointing this out. > I need to know if the patch is in good shape now, thanks It is not yet. Use the force^Wcheckpatch.pl. > you can look at the output of objdump -d to see why, also the assembly > snippet send by another person make this clear. You need to explain that in the commit message, my young padawan. Then you can join me. Together we can rule the galaxy like father and son. Your father, Darth. --- Sent from the Death Star. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web