Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1165024 > unrolled thread

[PATCH 1/1] net: replace if()/BUG with BUG_ON()

Started byManinder Singh <maninder1.s@samsung.com>
First post2015-06-15 07:10 +0200
Last post2015-06-16 02:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 1/1] net: replace if()/BUG with BUG_ON() Maninder Singh <maninder1.s@samsung.com> - 2015-06-15 07:10 +0200
    Re: [PATCH 1/1] net: replace if()/BUG with BUG_ON() David Miller <davem@davemloft.net> - 2015-06-16 02:20 +0200

#1165024 — [PATCH 1/1] net: replace if()/BUG with BUG_ON()

FromManinder Singh <maninder1.s@samsung.com>
Date2015-06-15 07:10 +0200
Subject[PATCH 1/1] net: replace if()/BUG with BUG_ON()
Message-ID<pBuOK-1Wc-19@gated-at.bofh.it>
Use BUG_ON(condition) instead of if(condition)/BUG()

Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Reviewed-by: Akhilesh Kumar <akhilesh.k@samsung.com>
---
 net/packet/af_packet.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index b5989c6..c91d405 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -547,8 +547,7 @@ static void prb_setup_retire_blk_timer(struct
packet_sock *po, int tx_ring)
 {
 	struct tpacket_kbdq_core *pkc;
 
-	if (tx_ring)
-		BUG();
+	BUG_ON(tx_ring);
 
 	pkc = tx_ring ? GET_PBDQC_FROM_RB(&po->tx_ring) :
 			GET_PBDQC_FROM_RB(&po->rx_ring);
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1165617

FromDavid Miller <davem@davemloft.net>
Date2015-06-16 02:20 +0200
Message-ID<pBMLD-2Cj-1@gated-at.bofh.it>
In reply to#1165024
From: Maninder Singh <maninder1.s@samsung.com>
Date: Mon, 15 Jun 2015 10:35:05 +0530

> Use BUG_ON(condition) instead of if(condition)/BUG()
> 
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Reviewed-by: Akhilesh Kumar <akhilesh.k@samsung.com>

Your email client corrupted this patch, making it unusable.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web