Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1165024

[PATCH 1/1] net: replace if()/BUG with BUG_ON()

From Maninder Singh <maninder1.s@samsung.com>
Newsgroups linux.kernel
Subject [PATCH 1/1] net: replace if()/BUG with BUG_ON()
Date 2015-06-15 07:10 +0200
Message-ID <pBuOK-1Wc-19@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


Use BUG_ON(condition) instead of if(condition)/BUG()

Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Reviewed-by: Akhilesh Kumar <akhilesh.k@samsung.com>
---
 net/packet/af_packet.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index b5989c6..c91d405 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -547,8 +547,7 @@ static void prb_setup_retire_blk_timer(struct
packet_sock *po, int tx_ring)
 {
 	struct tpacket_kbdq_core *pkc;
 
-	if (tx_ring)
-		BUG();
+	BUG_ON(tx_ring);
 
 	pkc = tx_ring ? GET_PBDQC_FROM_RB(&po->tx_ring) :
 			GET_PBDQC_FROM_RB(&po->rx_ring);
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/1] net: replace if()/BUG with BUG_ON() Maninder Singh <maninder1.s@samsung.com> - 2015-06-15 07:10 +0200
  Re: [PATCH 1/1] net: replace if()/BUG with BUG_ON() David Miller <davem@davemloft.net> - 2015-06-16 02:20 +0200

csiph-web