Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1164540 > unrolled thread

Re: [RFC PATCH v7 23/37] perf tools: Introduce llvm config options

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [RFC PATCH v7 23/37] perf tools: Introduce llvm config options pi3orama <pi3orama@163.com> - 2015-06-13 06:40 +0200
    Re: [RFC PATCH v7 23/37] perf tools: Introduce llvm config options Alexei Starovoitov <ast@plumgrid.com> - 2015-06-13 06:50 +0200

#1164540 — Re: [RFC PATCH v7 23/37] perf tools: Introduce llvm config options

发自我的 iPhone

> 在 2015年6月13日，上午10:31，Alexei Starovoitov <ast@plumgrid.com> 写道：
> 
>> On 6/11/15 10:35 PM, Wang Nan wrote:
>>         # Path to clang. If omit, search it from $PATH.
>>    clang-path = "/path/to/clang"
> 
> I think this bit and search_program() from the next patch is
> overly flexible. It's always delicate to search file paths.

About this clang-path: in my environment the name of clang is x86_64-oe-linux-clang, and installed in /usr/bin/llvm-3.7, neither in $PATH nor has its default name. This is the default setting of yocto and open-embedded based systems. Please see do_install part in building script of it:

https://github.com/openembedded/meta-oe/blob/master/meta-oe/recipes-core/llvm/llvm.inc

Therefore, I think something like this option should not be dropped, or people like me have to do some nasty work to make it useable. Could you please rethink it?

Thank you.

> Unless this is really needed, I would drop this bit.
> popen() in the next patch executes clang via shell,
> so explicit PATH search in unnecessary.
> 
> The rest of the patches look good to me.
> Thanks again.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1164541

On 6/12/15 9:11 PM, pi3orama wrote:
>
>
> 发自我的 iPhone
>
>> 在 2015年6月13日，上午10:31，Alexei Starovoitov <ast@plumgrid.com> 写道：
>>
>>> On 6/11/15 10:35 PM, Wang Nan wrote:
>>>          # Path to clang. If omit, search it from $PATH.
>>>     clang-path = "/path/to/clang"
>>
>> I think this bit and search_program() from the next patch is
>> overly flexible. It's always delicate to search file paths.
>
> About this clang-path: in my environment the name of clang is x86_64-oe-linux-clang, and installed in /usr/bin/llvm-3.7, neither in $PATH nor has its default name. This is the default setting of yocto and open-embedded based systems. Please see do_install part in building script of it:
>
> https://github.com/openembedded/meta-oe/blob/master/meta-oe/recipes-core/llvm/llvm.inc

well, that setup installs host backend only due to:
--enable-targets=host-only
in the above script,
whereas typical clang install on ubuntu/fedora includes all backends.
So in your case you'd need to install another clang.
I agree that the name can be different than just 'clang',
so yeah 'clang-path' is needed for this reason.
So I'm ok keeping patches 23 and 24 as-is.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web