Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1743266
| From | Bart Van Assche <Bart.VanAssche@wdc.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V7 2/6] block: tracking request allocation with q_usage_counter |
| Date | 2017-10-02 22:50 +0200 |
| Message-ID | <uwfPa-ur-135@gated-at.bofh.it> (permalink) |
| References | <uvji1-nu-3@gated-at.bofh.it> <uvji2-nu-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, 2017-09-30 at 14:12 +0800, Ming Lei wrote:
> @@ -1395,16 +1401,21 @@ static struct request *blk_old_get_request(struct request_queue *q,
> unsigned int op, gfp_t gfp_mask)
> {
> struct request *rq;
> + int ret = 0;
>
> WARN_ON_ONCE(q->mq_ops);
>
> /* create ioc upfront */
> create_io_context(gfp_mask, q->node);
>
> + ret = blk_queue_enter(q, !(gfp_mask & __GFP_DIRECT_RECLAIM));
> + if (ret)
> + return ERR_PTR(ret);
Can the above blk_queue_enter() call block if the REQ_NOWAIT flag has been
set in the op argument and e.g. gfp_mask == GFP_KERNEL? If so, isn't that a
bug?
Bart.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V7 0/6] block/scsi: safe SCSI quiescing Ming Lei <ming.lei@redhat.com> - 2017-09-30 08:20 +0200
[PATCH V7 5/6] block: support PREEMPT_ONLY Ming Lei <ming.lei@redhat.com> - 2017-09-30 08:20 +0200
Re: [PATCH V7 5/6] block: support PREEMPT_ONLY Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-10-02 22:50 +0200
[PATCH V7 2/6] block: tracking request allocation with q_usage_counter Ming Lei <ming.lei@redhat.com> - 2017-09-30 08:20 +0200
Re: [PATCH V7 2/6] block: tracking request allocation with q_usage_counter Christoph Hellwig <hch@infradead.org> - 2017-10-02 22:50 +0200
Re: [PATCH V7 2/6] block: tracking request allocation with q_usage_counter Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-10-02 22:50 +0200
[PATCH V7 4/6] block: prepare for passing RQF_PREEMPT to request allocation Ming Lei <ming.lei@redhat.com> - 2017-09-30 08:20 +0200
Re: [PATCH V7 0/6] block/scsi: safe SCSI quiescing Martin Steigerwald <martin@lichtvoll.de> - 2017-09-30 11:50 +0200
Re: [PATCH V7 0/6] block/scsi: safe SCSI quiescing Ming Lei <ming.lei@redhat.com> - 2017-09-30 12:00 +0200
csiph-web