Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1743237

Re: [PATCH V7 5/6] block: support PREEMPT_ONLY

Show all headers | View raw

On Sat, 2017-09-30 at 14:12 +0800, Ming Lei wrote:
> +void blk_set_preempt_only(struct request_queue *q, bool preempt_only)
> +{
> +	blk_mq_freeze_queue(q);
> +	if (preempt_only)
> +		queue_flag_set_unlocked(QUEUE_FLAG_PREEMPT_ONLY, q);
> +	else
> +		queue_flag_clear_unlocked(QUEUE_FLAG_PREEMPT_ONLY, q);
> +	blk_mq_unfreeze_queue(q);
> +}
> +EXPORT_SYMBOL(blk_set_preempt_only);
> +
>  /**
>   * __blk_run_queue_uncond - run a queue whether or not it has been stopped
>   * @q:	The queue to run
> @@ -771,9 +782,18 @@ int blk_queue_enter(struct request_queue *q, unsigned flags)
>  	while (true) {
>  		int ret;
>  
> +		/*
> +		 * preempt_only flag has to be set after queue is frozen,
> +		 * so it can be checked here lockless and safely
> +		 */
> +		if (blk_queue_preempt_only(q)) {
> +			if (!(flags & BLK_REQ_PREEMPT))
> +				goto slow_path;
> +		}
> +
>  		if (percpu_ref_tryget_live(&q->q_usage_counter))
>  			return 0;

Sorry but I don't think that it is possible with these changes to prevent
that a non-preempt request gets allocated after a (SCSI) queue has been
quiesced. If the CPU that calls blk_queue_enter() observes the set of the
PREEMPT_ONLY flag after the queue has been unfrozen and after the SCSI
device state has been changed into QUIESCED then blk_queue_enter() can
succeed for a non-preempt request. I think this is exactly the scenario
we want to avoid. This is why a synchronize_rcu() call is present in my
patch before the queue is unfrozen and also why in my patch the
percpu_ref_tryget_live() call occurs before the test of the PREEMPT_ONLY
flag.

Bart.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V7 0/6] block/scsi: safe SCSI quiescing Ming Lei <ming.lei@redhat.com> - 2017-09-30 08:20 +0200
  [PATCH V7 5/6] block: support PREEMPT_ONLY Ming Lei <ming.lei@redhat.com> - 2017-09-30 08:20 +0200
    Re: [PATCH V7 5/6] block: support PREEMPT_ONLY Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-10-02 22:50 +0200
  [PATCH V7 2/6] block: tracking request allocation with q_usage_counter Ming Lei <ming.lei@redhat.com> - 2017-09-30 08:20 +0200
    Re: [PATCH V7 2/6] block: tracking request allocation with  q_usage_counter Christoph Hellwig <hch@infradead.org> - 2017-10-02 22:50 +0200
    Re: [PATCH V7 2/6] block: tracking request allocation with  q_usage_counter Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-10-02 22:50 +0200
  [PATCH V7 4/6] block: prepare for passing RQF_PREEMPT to request allocation Ming Lei <ming.lei@redhat.com> - 2017-09-30 08:20 +0200
  Re: [PATCH V7 0/6] block/scsi: safe SCSI quiescing Martin Steigerwald <martin@lichtvoll.de> - 2017-09-30 11:50 +0200
    Re: [PATCH V7 0/6] block/scsi: safe SCSI quiescing Ming Lei <ming.lei@redhat.com> - 2017-09-30 12:00 +0200

csiph-web