Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1743254

Re: [PATCH] writeback: remove unused parameter from balance_dirty_pages()

From Tahsin Erdogan <tahsin@google.com>
Newsgroups linux.kernel
Subject Re: [PATCH] writeback: remove unused parameter from balance_dirty_pages()
Date 2017-10-02 22:50 +0200
Message-ID <uwfP8-ur-99@gated-at.bofh.it> (permalink)
References <uusQp-sS-3@gated-at.bofh.it> <uw3NV-4As-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Oct 2, 2017 at 12:56 AM, Michal Hocko <mhocko@kernel.org> wrote:
> balance_dirty_pages_ratelimited doesn't really need mapping as well. All
> it needs is the inode and we already have it in callers. So would it
> make sense to refactor a bit further and make its argument an inode?

My only concern is that, balance_dirty_pages_ratelimited() is an
exported function so changing its signature could potentially break
some drivers?

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] writeback: remove unused parameter from balance_dirty_pages() Tahsin Erdogan <tahsin@google.com> - 2017-09-28 00:20 +0200
  Re: [PATCH] writeback: remove unused parameter from  balance_dirty_pages() Michal Hocko <mhocko@kernel.org> - 2017-10-02 10:00 +0200
    Re: [PATCH] writeback: remove unused parameter from balance_dirty_pages() Tahsin Erdogan <tahsin@google.com> - 2017-10-02 22:50 +0200
      Re: [PATCH] writeback: remove unused parameter from  balance_dirty_pages() Michal Hocko <mhocko@kernel.org> - 2017-10-02 22:50 +0200

csiph-web