Re: [PATCH 1/3] scsi: ufs: Change HCI marco to actual bit position

Path	csiph.com!news.redatomik.org!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Bart Van Assche <Bart.VanAssche@wdc.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] scsi: ufs: Change HCI marco to actual bit position
Date	Mon, 02 Oct 2017 22:50:05 +0200
Message-ID	<uwfP7-ur-83@gated-at.bofh.it> (permalink)
References	<uvjBo-uO-21@gated-at.bofh.it> <uvjBo-uO-13@gated-at.bofh.it>
X-Ironport-Av	E=Sophos;i="5.42,470,1500912000"; d="scan'208";a="56014193"
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=LUIWAII6+b11Eiul+iY+XKaui/ArTG3rmAe8bCZ4T3M=; b=HlklRIDkPKnli1+HzOYJFX4gSz6833e+DnymuoMULJjqdLY9AJt6bLLgohjQh+jY1ueEii8PfPTGdfKog/CLj9+gfDwy0Trv63LveDkjESnurmNuUVN1/qxqjXSdUVcoMR+QjJCcyZFep8PLa+qmoeHnYeMvTJxiIp98lI/ALAQ=
Thread-Topic	[PATCH 1/3] scsi: ufs: Change HCI marco to actual bit position
Thread-Index	AQHTObWPebP72mOrS0GAxdaK0iEK5aLQxzGA
Accept-Language	en-US
Content-Language	en-US
Authentication-Results	spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com;
X-Originating-IP	[63.163.107.100]
X-Ms-Publictraffictype	Email
X-Microsoft-Exchange-Diagnostics	1;CY1PR0401MB1534;20:rWxXtuRlh8msESz+zYHXUhhXpMGtBcDrFNHBUI4nzpu7Wf4lfMG7cbfBc0mrilgppojx8WunnvMjelomFpewJTEWNBXuh+1JW0L/TRs5WShOwgzQcpEwp05l82naz37ZqNppyGq7huT5dXvkRYlypZGBZCDgyQnoaNCQqElD4u0=
X-Ms-Exchange-Antispam-Srfa-Diagnostics	SSOS;
X-Ms-Office365-Filtering-Correlation-ID	49b2a770-bbb6-4ac3-487c-08d509b47199
X-Ms-Office365-Filtering-Ht	Tenant
X-Microsoft-Antispam	UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CY1PR0401MB1534;
X-Ms-Traffictypediagnostic	CY1PR0401MB1534:
Wdcipoutbound	EOP-TRUE
X-Exchange-Antispam-Report-Test	UriScan:;
X-Microsoft-Antispam-Prvs	<CY1PR0401MB1534D0EE53C6B326C4A18A4D987D0@CY1PR0401MB1534.namprd04.prod.outlook.com>
X-Exchange-Antispam-Report-Cfa-Test	BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123560025)(20161123558100)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1534;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1534;
X-Forefront-Prvs	0448A97BF2
X-Forefront-Antispam-Report	SFV:NSPM;SFS:(10019020)(6009001)(376002)(39860400002)(346002)(377424004)(189002)(24454002)(199003)(189998001)(81156014)(68736007)(4326008)(478600001)(6506006)(305945005)(6512007)(7736002)(53936002)(2201001)(3660700001)(2906002)(72206003)(316002)(99286003)(54906003)(76176999)(54356999)(50986999)(14454004)(39060400002)(3280700002)(110136005)(66066001)(101416001)(103116003)(5660300001)(2501003)(6116002)(86362001)(3846002)(102836003)(77096006)(6486002)(2900100001)(106356001)(81166006)(8676002)(105586002)(2950100002)(6436002)(6246003)(36756003)(97736004)(8936002)(33646002)(25786009)(229853002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1534;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en;
Spamdiagnosticoutput	1:99
Spamdiagnosticmetadata	NSPM
Content-Type	text/plain; charset="utf-8"
Content-ID	<177C3BC7DEB81148924CBA2C45063A74@namprd04.prod.outlook.com>
Content-Transfer-Encoding	base64
MIME-Version	1.0
X-Originatororg	wdc.com
X-Ms-Exchange-Crosstenant-Originalarrivaltime	02 Oct 2017 16:41:34.6333 (UTC)
X-Ms-Exchange-Crosstenant-Fromentityheader	Hosted
X-Ms-Exchange-Crosstenant-ID	b61c8803-16f3-4c35-9b17-6f65f441df86
X-Ms-Exchange-Transport-Crosstenantheadersstamped	CY1PR0401MB1534
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	13
Organization	linux.* mail to news gateway
X-Original-Cc	"subhashj@codeaurora.org" <subhashj@codeaurora.org>, "martin.petersen@oracle.com" <martin.petersen@oracle.com>, "vinholikatti@gmail.com" <vinholikatti@gmail.com>
X-Original-Date	Mon, 2 Oct 2017 16:41:34 +0000
X-Original-Message-ID	<1506962493.3368.35.camel@wdc.com>
X-Original-References	<CGME20170930062956epcas1p1461ea07e21a275a9e5733b3b90b5896a@epcas1p1.samsung.com> <1506752526-27014-1-git-send-email-alim.akhtar@samsung.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1743248

Show key headers only | View raw

On Sat, 2017-09-30 at 11:52 +0530, Alim Akhtar wrote:
> Currently UFS HCI uses UFS_BIT() macro to get various bit
> position for the hardware registers status bits. Which makes
> code longer instead of shorter. This macro does not improve
> code readability as well.
> Lets re-write these macro definition with the actual bit position.

Can the three patches in this series be combined into a single patch?

> -#define UFS_BIT(x)	(1L << (x))
> [ ... ]
> +#define UFS_BIT(x)     (1L << (x))

If you want to keep the three patches separate, please make sure that this
patch does not modify the UFS_BIT() definition. Please also fix the spelling
of the title of this patch (marco -> macro).

Thanks,

Bart.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] scsi: ufs: Change HCI marco to actual bit position Alim Akhtar <alim.akhtar@samsung.com> - 2017-09-30 08:40 +0200
  [PATCH 3/3] scsi: ufs: Remove unused UFS_BIT() macro Alim Akhtar <alim.akhtar@samsung.com> - 2017-09-30 08:40 +0200
  Re: [PATCH 1/3] scsi: ufs: Change HCI marco to actual bit position Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-10-02 22:50 +0200

csiph-web