Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1743015

Re: btusb "firmware request while host is not available" at resume

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Kai-Heng Feng <kai.heng.feng@canonical.com>
Newsgroups linux.kernel
Subject Re: btusb "firmware request while host is not available" at resume
Date Mon, 02 Oct 2017 10:40:01 +0200
Message-ID <uw4qB-52e-1@gated-at.bofh.it> (permalink)
References <uonTr-5wo-7@gated-at.bofh.it> <uoowa-67j-3@gated-at.bofh.it> <uopix-6K2-1@gated-at.bofh.it> <uoxg6-3Y7-9@gated-at.bofh.it> <uoAxj-6lq-5@gated-at.bofh.it> <uoCIO-7F7-15@gated-at.bofh.it> <uoDbQ-84z-23@gated-at.bofh.it> <uoLM5-5ru-5@gated-at.bofh.it> <uoWet-3Az-5@gated-at.bofh.it> <up9Op-3SS-13@gated-at.bofh.it> <upjXr-1Yv-1@gated-at.bofh.it>
X-Original-To "Luis R. Rodriguez" <mcgrof@kernel.org>
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=FO6hOA1BUrFFb1TtcEiCcLtsxdv9lTlKN47efy/Nx9A=; b=VRJYAxLVVgr5z3lM3Z/LFH4BUT8UU8AgIIxBF78nYJlkDueLyat45rgwTzrrBs+4Y/ Dw1vEMOHKGPzFYUJ1sNG+279NLrf/oJAkv2NJ2xmUZnnSYtjcz9M9xXq4KVOJ2V/DQvE ix7zmdrmGj18tlH9rL9fy4co8UgmP+mdXqxprCAg9TNhscwNn8UTA7oHjEbpRnixeAro vWfKnLflnskSnFucKSKYL0JxHpf48Ecb2ofYPvGeBz83DOvQGPYKX/PzM5hOevm085wf ZKZie9UvnLazn7i9VglZb6bll9AB4KHfGCqe9C/gqFV91ZUIbhxkycn2+7jwkdxLUT6P Pu3w==
X-Gm-Message-State AMCzsaX3d4cAlRk13asdwy9i+RDD+uBFPIKf2XglMUpsTMYArMudtsHJ nj/YdMl2XgdRnxKO/W9LZl4dVxTbupTA8yg4dIgW+tCD/HnpHCZRBL5ZHY3HWThhFkCwnvw9O5w 5n7eTrWT6szvblHmdIedlHncZ7dSf8Kzc6qUhrBhULr0U6uBm/ZADAOUneg==
X-Received by 10.202.237.202 with SMTP id l193mr1319927oih.317.1506933252410; Mon, 02 Oct 2017 01:34:12 -0700 (PDT)
X-Google-SMTP-Source AOwi7QBw0EdRwKY7ilZBX20o2c0MnY1x9aFpl4ppjc1bI4Evt3M3kC7QZCu7Ucwz2QwspJwZSfn+bxGPD+ibyUDewGA=
X-Received by 10.202.237.202 with SMTP id l193mr1319915oih.317.1506933252179; Mon, 02 Oct 2017 01:34:12 -0700 (PDT)
MIME-Version 1.0
Content-Type text/plain; charset="UTF-8"
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 35
Organization linux.* mail to news gateway
X-Original-Cc Marcel Holtmann <marcel@holtmann.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Linus Torvalds <torvalds@linux-foundation.org>, Gabriel C <nix.or.die@gmail.com>, Tejun Heo <tj@kernel.org>, "Gustavo F. Padovan" <gustavo@padovan.org>, Sukumar Ghorai <sukumar.ghorai@intel.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "bluez mailin list (linux-bluetooth@vger.kernel.org)" <linux-bluetooth@vger.kernel.org>
X-Original-Date Mon, 2 Oct 2017 16:34:11 +0800
X-Original-Message-ID <CAAd53p4NEL0XvYjPagYuTjHCJyW5jz20cLsf0GU91KvRax17oQ@mail.gmail.com>
X-Original-References <d68738f6-b079-0fef-dd9c-dca75e756c42@gmail.com> <CA+55aFzWABZ+KCKT+r+TgyrWfnc+6YE7ZuHhZmgw-cRQXWTQ2w@mail.gmail.com> <E31F8274-519A-4ED7-90C0-2BB71C9CC3ED@holtmann.org> <20170911134647.GA3980@kroah.com> <20170911171138.GA16216@wotan.suse.de> <20170911192955.GB23729@kroah.com> <20170911200651.GB16216@wotan.suse.de> <09F52990-796D-4F19-957B-EEFCA6ADC160@holtmann.org> <20170912162729.GC16216@wotan.suse.de> <3A938253-4CB7-4D24-82B1-6A2E3B794077@holtmann.org> <20170913173957.GM16216@wotan.suse.de>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1743015

Show key headers only | View raw


Hi Luis,

On Thu, Sep 14, 2017 at 1:39 AM, Luis R. Rodriguez <mcgrof@kernel.org> wrote:
[snipped]
> Would a fw_cache_hint(device, name_list) be reasonable then sometime *before*
> suspend? All this would do is ask the firmware API to extend the fw cache
> list with the entries. It would not load firmware immediately, instead this
> would trigger a request for the hinted firmware to become available for
> suspend. Then these drivers could request for firmware at resume and it
> will pick up the cached firmware.

I think I am the author the patch [1] mentioned by Marcel. I have to
admit, it's quite
clunky in it's current form.
So yes, the new API you proposed is definitely better to solve the
issue. I'll send
new patch for btusb once we have the new API to use.

Also, with patch [1], the "firmware request while host is not
available" may still get hit
on some corner cases. I proposed another patch [2] to tackle the edge
case, can you
take a look?

[1] https://lkml.org/lkml/2017/8/25/58
[2] https://lkml.org/lkml/2017/8/22/123

Kai-Heng

>
>   Luis
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: btusb "firmware request while host is not available" at resume Kai-Heng Feng <kai.heng.feng@canonical.com> - 2017-10-02 10:40 +0200

csiph-web