Re: [PATCH] powernv: Add OCC driver to mmap sensor area

From	Benjamin Herrenschmidt <benh@au1.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] powernv: Add OCC driver to mmap sensor area
Date	2017-10-02 10:40 +0200
Message-ID	<uw4qC-52e-5@gated-at.bofh.it> (permalink)
References	<uuXrb-2L2-3@gated-at.bofh.it> <uvZqV-289-1@gated-at.bofh.it>
Organization	IBM Australia

Show all headers | View raw

On Mon, 2017-10-02 at 14:14 +1100, Stewart Smith wrote:
> Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> writes:
> > This driver provides interface to mmap the OCC sensor area
> > to userspace to parse and read OCC inband sensors.
> 
> Why?
> 
> Is this for debug? If so, the existing exports interface should be used.
> 
> If there's actual sensors, we already have two ways of exposing sensors
> to Linux: the OPAL_SENSOR API and the IMC API.
> 
> Why this method and not use the existing ones?

More than that, a sensor should be exposed to userspace via hwmon, not
some random direct userspace map.

Ben.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] powernv: Add OCC driver to mmap sensor area Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2017-09-29 09:00 +0200
  Re: [PATCH] powernv: Add OCC driver to mmap sensor area Oliver <oohall@gmail.com> - 2017-09-29 09:50 +0200
  Re: [PATCH] powernv: Add OCC driver to mmap sensor area Stewart Smith <stewart@linux.vnet.ibm.com> - 2017-10-02 05:20 +0200
    Re: [PATCH] powernv: Add OCC driver to mmap sensor area Benjamin Herrenschmidt <benh@au1.ibm.com> - 2017-10-02 10:40 +0200

csiph-web