[PATCH 2/2] clk/versatile: Improve a size determination in icst_clk_setup()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] clk/versatile: Improve a size determination in icst_clk_setup()
Date	2017-09-27 21:50 +0200
Message-ID	<uuqvf-7kB-3@gated-at.bofh.it> (permalink)
References	<uuqlA-7fu-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 27 Sep 2017 21:24:43 +0200

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/clk/versatile/clk-icst.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/versatile/clk-icst.c b/drivers/clk/versatile/clk-icst.c
index 20ab4ceffb28..dafe7a45875d 100644
--- a/drivers/clk/versatile/clk-icst.c
+++ b/drivers/clk/versatile/clk-icst.c
@@ -359,7 +359,7 @@ static struct clk *icst_clk_setup(struct device *dev,
 	struct clk_init_data init;
 	struct icst_params *pclone;
 
-	icst = kzalloc(sizeof(struct clk_icst), GFP_KERNEL);
+	icst = kzalloc(sizeof(*icst), GFP_KERNEL);
 	if (!icst)
 		return ERR_PTR(-ENOMEM);
 
-- 
2.14.2

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] versatile clock: Adjustments for icst_clk_setup() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-27 21:40 +0200
  [PATCH 1/2] clk/versatile: Delete two error messages for a failed  memory allocation in icst_clk_setup() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-27 21:40 +0200
  [PATCH 2/2] clk/versatile: Improve a size determination in  icst_clk_setup() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-27 21:50 +0200

csiph-web