Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1740968
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/2] clk/versatile: Delete two error messages for a failed memory allocation in icst_clk_setup() |
| Date | 2017-09-27 21:40 +0200 |
| Message-ID | <uuqlA-7fu-21@gated-at.bofh.it> (permalink) |
| References | <uuqlA-7fu-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 27 Sep 2017 21:21:23 +0200
Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/clk/versatile/clk-icst.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/clk/versatile/clk-icst.c b/drivers/clk/versatile/clk-icst.c
index 09fbe66f1f11..20ab4ceffb28 100644
--- a/drivers/clk/versatile/clk-icst.c
+++ b/drivers/clk/versatile/clk-icst.c
@@ -360,15 +360,12 @@ static struct clk *icst_clk_setup(struct device *dev,
struct icst_params *pclone;
icst = kzalloc(sizeof(struct clk_icst), GFP_KERNEL);
- if (!icst) {
- pr_err("could not allocate ICST clock!\n");
+ if (!icst)
return ERR_PTR(-ENOMEM);
- }
pclone = kmemdup(desc->params, sizeof(*pclone), GFP_KERNEL);
if (!pclone) {
kfree(icst);
- pr_err("could not clone ICST params\n");
return ERR_PTR(-ENOMEM);
}
--
2.14.2
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] versatile clock: Adjustments for icst_clk_setup() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-27 21:40 +0200 [PATCH 1/2] clk/versatile: Delete two error messages for a failed memory allocation in icst_clk_setup() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-27 21:40 +0200 [PATCH 2/2] clk/versatile: Improve a size determination in icst_clk_setup() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-27 21:50 +0200
csiph-web