Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1740752

Re: [PATCH] mm, swap: Make VMA based swap readahead configurable

From Michal Hocko <mhocko@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] mm, swap: Make VMA based swap readahead configurable
Date 2017-09-27 16:00 +0200
Message-ID <uul2x-3HA-13@gated-at.bofh.it> (permalink)
References (4 earlier) <uufzQ-8dG-23@gated-at.bofh.it> <uug2S-8no-15@gated-at.bofh.it> <uukpR-3b4-37@gated-at.bofh.it> <uukzv-3iO-1@gated-at.bofh.it> <uukSS-3A0-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed 27-09-17 22:41:17, Minchan Kim wrote:
> On Wed, Sep 27, 2017 at 03:22:41PM +0200, Michal Hocko wrote:
[...]
> > simply cannot disable swap readahead when page-cluster is 0?
> 
> That's was what I want really but Huang want to use two readahead
> algorithms in parallel so he wanted to keep two separated disable
> knobs.

If it breaks existing and documented behavior then it is a clear
regression and it should be fixed. I do not see why this should be
disputable at all.

Working around an issue with a config option sounds like the wrong way
to go because those who cannot do that unconditionally would still see a
regression.
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mm, swap: Make VMA based swap readahead configurable Minchan Kim <minchan@kernel.org> - 2017-09-27 07:10 +0200
  Re: [PATCH] mm, swap: Make VMA based swap readahead configurable Michal Hocko <mhocko@kernel.org> - 2017-09-27 09:50 +0200
    Re: [PATCH] mm, swap: Make VMA based swap readahead configurable Minchan Kim <minchan@kernel.org> - 2017-09-27 10:10 +0200
      Re: [PATCH] mm, swap: Make VMA based swap readahead configurable Michal Hocko <mhocko@kernel.org> - 2017-09-27 10:40 +0200
        Re: [PATCH] mm, swap: Make VMA based swap readahead configurable Minchan Kim <minchan@kernel.org> - 2017-09-27 15:20 +0200
          Re: [PATCH] mm, swap: Make VMA based swap readahead configurable Michal Hocko <mhocko@kernel.org> - 2017-09-27 15:30 +0200
            Re: [PATCH] mm, swap: Make VMA based swap readahead configurable Minchan Kim <minchan@kernel.org> - 2017-09-27 15:50 +0200
              Re: [PATCH] mm, swap: Make VMA based swap readahead configurable Michal Hocko <mhocko@kernel.org> - 2017-09-27 16:00 +0200
                Re: [PATCH] mm, swap: Make VMA based swap readahead configurable Minchan Kim <minchan@kernel.org> - 2017-09-27 16:20 +0200
                Re: [PATCH] mm, swap: Make VMA based swap readahead configurable Michal Hocko <mhocko@kernel.org> - 2017-09-27 16:20 +0200
                Re: [PATCH] mm, swap: Make VMA based swap readahead configurable "Huang\, Ying" <ying.huang@intel.com> - 2017-09-28 03:10 +0200
                Re: [PATCH] mm, swap: Make VMA based swap readahead configurable Michal Hocko <mhocko@kernel.org> - 2017-10-02 09:30 +0200
                Re: [PATCH] mm, swap: Make VMA based swap readahead configurable Dave Hansen <dave.hansen@intel.com> - 2017-10-02 22:50 +0200

csiph-web