Re: [PATCH] netlink: do not proceed if dump's start() errs

From	Johannes Berg <johannes@sipsolutions.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] netlink: do not proceed if dump's start() errs
Date	2017-09-27 15:10 +0200
Message-ID	<uukg9-35a-7@gated-at.bofh.it> (permalink)
References	<uujWO-2Bu-23@gated-at.bofh.it> <uuk6v-2Hs-21@gated-at.bofh.it> <uukga-35a-27@gated-at.bofh.it> <uuk6v-2Hs-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2017-09-27 at 14:50 +0200, Jason A. Donenfeld wrote:
> On Wed, Sep 27, 2017 at 2:39 PM, Jason A. Donenfeld <Jason@zx2c4.com>
> wrote:
> > -       if (cb->start)
> > -               cb->start(cb);
> > +       if (cb->start) {
> > +               ret = cb->start(cb);
> > +               if (ret)
> 
> I need to sock_put(sk); before returning. I'll fix this for v2, but
> will for additional comments in case anybody has some.

I guess you could change it to

if (cb->start)
	ret = cb->start(cb);
if (!ret)
	ret = netlink_dump(sk);

johannes

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] netlink: do not proceed if dump's start() errs "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-09-27 14:50 +0200
  Re: [PATCH] netlink: do not proceed if dump's start() errs "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-09-27 15:00 +0200
    Re: [PATCH] netlink: do not proceed if dump's start() errs "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-09-27 15:10 +0200
      [PATCH v2] netlink: do not proceed if dump's start() errs "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-09-28 00:50 +0200
        Re: [PATCH v2] netlink: do not proceed if dump's start() errs "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-09-28 12:50 +0200
        Re: [PATCH v2] netlink: do not proceed if dump's start() errs David Miller <davem@davemloft.net> - 2017-09-30 08:30 +0200
        Re: [PATCH v2] netlink: do not proceed if dump's start() errs Johannes Berg <johannes@sipsolutions.net> - 2017-09-30 09:40 +0200
          Re: [PATCH v2] netlink: do not proceed if dump's start() errs David Miller <davem@davemloft.net> - 2017-09-30 17:20 +0200
    Re: [PATCH] netlink: do not proceed if dump's start() errs Johannes Berg <johannes@sipsolutions.net> - 2017-09-27 15:10 +0200

csiph-web