Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1740699

Re: [PATCH] netlink: do not proceed if dump's start() errs

Show all headers | View raw

On Wed, Sep 27, 2017 at 3:05 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> I guess you could change it to
>
> if (cb->start)
>         ret = cb->start(cb);
> if (!ret)
>         ret = netlink_dump(sk);

Very clean. I'll do it like that. I'll wait a bit longer before
submitting v2, but beyond that, seems sane to you?

Jason

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] netlink: do not proceed if dump's start() errs "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-09-27 14:50 +0200
  Re: [PATCH] netlink: do not proceed if dump's start() errs "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-09-27 15:00 +0200
    Re: [PATCH] netlink: do not proceed if dump's start() errs "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-09-27 15:10 +0200
      [PATCH v2] netlink: do not proceed if dump's start() errs "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-09-28 00:50 +0200
        Re: [PATCH v2] netlink: do not proceed if dump's start() errs "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-09-28 12:50 +0200
        Re: [PATCH v2] netlink: do not proceed if dump's start() errs David Miller <davem@davemloft.net> - 2017-09-30 08:30 +0200
        Re: [PATCH v2] netlink: do not proceed if dump's start() errs Johannes Berg <johannes@sipsolutions.net> - 2017-09-30 09:40 +0200
          Re: [PATCH v2] netlink: do not proceed if dump's start() errs David Miller <davem@davemloft.net> - 2017-09-30 17:20 +0200
    Re: [PATCH] netlink: do not proceed if dump's start() errs Johannes Berg <johannes@sipsolutions.net> - 2017-09-27 15:10 +0200

csiph-web