Re: [PATCH v2 05/10] arm: dts: mt7623: update pio, usb and crypto nodes

From	Ryder Lee <ryder.lee@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 05/10] arm: dts: mt7623: update pio, usb and crypto nodes
Date	2017-09-27 05:30 +0200
Message-ID	<uubcR-5fT-1@gated-at.bofh.it> (permalink)
References	<utNtT-6AN-1@gated-at.bofh.it> <utNtU-6AN-17@gated-at.bofh.it> <utV85-3qz-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2017-09-26 at 18:17 +0800, Yingjoe Chen wrote:
> On Tue, 2017-09-26 at 10:02 +0800, Ryder Lee wrote:
> > This patch updates pio, usb and crypto nodes to make them be consistent
> > with the binding documents.
> > 
> > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> > ---
> >  arch/arm/boot/dts/mt7623.dtsi | 52 ++++++++++++++++++++++---------------------
> >  1 file changed, 27 insertions(+), 25 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi
> > index 381843e..9ec3767 100644
> > --- a/arch/arm/boot/dts/mt7623.dtsi
> > +++ b/arch/arm/boot/dts/mt7623.dtsi
> > @@ -226,21 +226,6 @@
> >  		#reset-cells = <1>;
> >  	};
> >  
> > -	pio: pinctrl@10005000 {
> > -		compatible = "mediatek,mt7623-pinctrl",
> > -			     "mediatek,mt2701-pinctrl";
> > -		reg = <0 0x1000b000 0 0x1000>;
> > -		mediatek,pctl-regmap = <&syscfg_pctl_a>;
> > -		pins-are-numbered;
> > -		gpio-controller;
> > -		#gpio-cells = <2>;
> > -		interrupt-controller;
> > -		interrupt-parent = <&gic>;
> > -		#interrupt-cells = <2>;
> > -		interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>,
> > -			     <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>;
> > -	};
> > -
> >  	syscfg_pctl_a: syscfg@10005000 {
> >  		compatible = "mediatek,mt7623-pctl-a-syscfg", "syscon";
> >  		reg = <0 0x10005000 0 0x1000>;
> 
> 
> Hi Ryder,
> 
> pio node is special, it have 2 registers space.
> The address 10005000 is for PIO, it was accesed through syscfg_pctl_a
> regmap. The other one, 0x1000b000, is for EINT.
> 
> So,I think using address @10005000 is correct.
> 
> Joe.C
> 

Thanks for explanation. I'll revert this part to a previous state.

>

Thread

[PATCH v2 00/10] update MT7623 and MT2701 dts Ryder Lee <ryder.lee@mediatek.com> - 2017-09-26 04:10 +0200
  [PATCH v2 03/10] arm: dts: mt2701: add display subsystem related nodes Ryder Lee <ryder.lee@mediatek.com> - 2017-09-26 04:10 +0200
  [PATCH v2 06/10] arm: dts: mt7623: add subsystem clock controller nodes Ryder Lee <ryder.lee@mediatek.com> - 2017-09-26 04:10 +0200
  [PATCH v2 09/10] arm: dts: mt7623: enable bananapi-r2 display function Ryder Lee <ryder.lee@mediatek.com> - 2017-09-26 04:10 +0200
  [PATCH v2 04/10] arm: dts: mediatek: update audio node for mt2701 and mt7623 Ryder Lee <ryder.lee@mediatek.com> - 2017-09-26 04:10 +0200
  [PATCH v2 05/10] arm: dts: mt7623: update pio, usb and crypto nodes Ryder Lee <ryder.lee@mediatek.com> - 2017-09-26 04:10 +0200
    Re: [PATCH v2 05/10] arm: dts: mt7623: update pio, usb and crypto  nodes Yingjoe Chen <yingjoe.chen@mediatek.com> - 2017-09-26 12:20 +0200
      Re: [PATCH v2 05/10] arm: dts: mt7623: update pio, usb and crypto  nodes Ryder Lee <ryder.lee@mediatek.com> - 2017-09-27 05:30 +0200
  [PATCH v2 02/10] arm: dts: mt2701: enable display pwm backlight Ryder Lee <ryder.lee@mediatek.com> - 2017-09-26 04:10 +0200
  [PATCH v2 01/10] arm: dts: mt2701: add pwm backlight device node Ryder Lee <ryder.lee@mediatek.com> - 2017-09-26 04:10 +0200
  [PATCH v2 07/10] arm: dts: mt7623: add iommmu and jpecdec nodes Ryder Lee <ryder.lee@mediatek.com> - 2017-09-26 04:10 +0200
  [PATCH v2 08/10] arm: dts: mt7623: add display subsystem related nodes Ryder Lee <ryder.lee@mediatek.com> - 2017-09-26 04:10 +0200
  [PATCH v2 10/10] arm: dts: mt7623: add PCIe related nodes Ryder Lee <ryder.lee@mediatek.com> - 2017-09-26 04:10 +0200

csiph-web