Re: [PATCH for-next 8/9] RDMA/hns: Remove unused struct members in hns-abi.h

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	"Wei Hu (Xavier)" <xavier.huwei@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH for-next 8/9] RDMA/hns: Remove unused struct members in hns-abi.h
Date	Thu, 28 Sep 2017 14:00:01 +0200
Message-ID	<uuFDX-8w4-3@gated-at.bofh.it> (permalink)
References	<uuyCt-49t-3@gated-at.bofh.it> <uuyM9-4cw-1@gated-at.bofh.it> <uuCZs-743-25@gated-at.bofh.it>
User-Agent	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1
MIME-Version	1.0
Content-Type	text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding	7bit
X-Originating-IP	[10.57.115.182]
X-Cfilter-Loop	Reflected
X-Mirapoint-Virus-Rapid-Raw	score=unknown(0), refid=str=0001.0A010206.59CCE381.0071,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-ID	0c6007f43158a937428e0a94b734ce3a
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	63
Organization	linux.* mail to news gateway
X-Original-Cc	<dledford@redhat.com>, <linux-rdma@vger.kernel.org>, <lijun_nudt@163.com>, <oulijun@huawei.com>, <charles.chenxin@huawei.com>, <liuyixian@huawei.com>, <xushaobo2@huawei.com>, <zhangxiping3@huawei.com>, <xavier.huwei@tom.com>, <linuxarm@huawei.com>, <linux-kernel@vger.kernel.org>, <shaobohsu@163.com>
X-Original-Date	Thu, 28 Sep 2017 19:56:40 +0800
X-Original-Message-ID	<59CCE378.6070209@huawei.com>
X-Original-References	<1506574654-56699-1-git-send-email-xavier.huwei@huawei.com> <1506574654-56699-9-git-send-email-xavier.huwei@huawei.com> <20170928090203.GS2297@mtr-leonro.local>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1741468

Show key headers only | View raw


On 2017/9/28 17:02, Leon Romanovsky wrote:
> On Thu, Sep 28, 2017 at 12:57:33PM +0800, Wei Hu (Xavier) wrote:
>> From: Lijun Ou <oulijun@huawei.com>
>>
>> This patch mainly deletes some unused struct members for
>> hns_roce_ib_create_qp in order to match libhns, because
>> the num of struct members of hns_roce_ib_create_qp must
>> be the same with hns_roce_create_qp in libhns.
>>
>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
>> Signed-off-by: Shaobo Xu <xushaobo2@huawei.com>
>> ---
>>   include/uapi/rdma/hns-abi.h | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/include/uapi/rdma/hns-abi.h b/include/uapi/rdma/hns-abi.h
>> index 5d74019..79251b6 100644
>> --- a/include/uapi/rdma/hns-abi.h
>> +++ b/include/uapi/rdma/hns-abi.h
>> @@ -41,10 +41,8 @@ struct hns_roce_ib_create_cq {
>>
>>   struct hns_roce_ib_create_qp {
>>   	__u64	buf_addr;
>> -	__u64   db_addr;
>>   	__u8    log_sq_bb_count;
>>   	__u8    log_sq_stride;
>> -	__u8    sq_no_prefetch;
>>   	__u8    reserved[5];
>>   };
> It is classical UAPI breakage which kernel tries to avoid.
>
> In RDMA, we do allow rename of fields from reserved to something, but
> don't allow binary layout change.
>
> NAK to this change.
>
> Thanks
Hi, Leon
     Now there is an inconsistency between hns_roce_ib_create_qp in 
kernel driver and hns_roce_create_qp  in libhns as below:

struct hns_roce_create_qp {
     struct ibv_create_qp        ibv_cmd;
     __u64                buf_addr;
     __u8                log_sq_bb_count;
     __u8                log_sq_stride;
     __u8                reserved[5];
};
     It is better to modify hns_roce_create_qp in libhns, right?
     Thanks

     Regards
Wei Hu
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thread

[PATCH for-next 8/9] RDMA/hns: Remove unused struct members in hns-abi.h "Wei Hu (Xavier)" <xavier.huwei@huawei.com> - 2017-09-28 06:40 +0200
  Re: [PATCH for-next 8/9] RDMA/hns: Remove unused struct members in  hns-abi.h Leon Romanovsky <leon@kernel.org> - 2017-09-28 11:10 +0200
    Re: [PATCH for-next 8/9] RDMA/hns: Remove unused struct members in  hns-abi.h "Wei Hu (Xavier)" <xavier.huwei@huawei.com> - 2017-09-28 14:00 +0200
      Re: [PATCH for-next 8/9] RDMA/hns: Remove unused struct members in  hns-abi.h Leon Romanovsky <leon@kernel.org> - 2017-09-28 15:10 +0200
        Re: [PATCH for-next 8/9] RDMA/hns: Remove unused struct members in  hns-abi.h "Wei Hu (Xavier)" <xavier.huwei@tom.com> - 2017-09-28 18:20 +0200

csiph-web