Re: [PATCH 4/5] scsi/ufs: qcom: Set phy mode based on the controllers HS MODE

From	Subhash Jadavani <subhashj@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/5] scsi/ufs: qcom: Set phy mode based on the controllers HS MODE
Date	2017-09-27 00:50 +0200
Message-ID	<uu6PT-2mP-9@gated-at.bofh.it> (permalink)
References	<uaEAN-3uH-5@gated-at.bofh.it> <uaEAO-3uH-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2017-08-03 23:48, Vivek Gautam wrote:
> Set the phy mode based on the UFS HS PA mode. This lets the
> controller let phy know the mode in which the PHY Adapter is
> running and set the phy rates accordingly.
> 
> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
> ---
>  drivers/scsi/ufs/ufs-qcom.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
> index c87d770b519a..44c21d5818ee 100644
> --- a/drivers/scsi/ufs/ufs-qcom.c
> +++ b/drivers/scsi/ufs/ufs-qcom.c
> @@ -273,6 +273,9 @@ static int ufs_qcom_power_up_sequence(struct 
> ufs_hba *hba)
>  	bool is_rate_B = (UFS_QCOM_LIMIT_HS_RATE == PA_HS_MODE_B)
>  							? true : false;
> 
> +	if (is_rate_B)
> +		phy_set_mode(phy, PHY_MODE_UFS_HS_B);
> +
>  	/* Assert PHY reset and apply PHY calibration values */
>  	ufs_qcom_assert_reset(hba);
>  	/* provide 1ms delay to let the reset pulse propagate */

Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 4/5] scsi/ufs: qcom: Set phy mode based on the controllers  HS MODE Subhash Jadavani <subhashj@codeaurora.org> - 2017-09-27 00:50 +0200
  Re: [PATCH 4/5] scsi/ufs: qcom: Set phy mode based on the controllers  HS MODE Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-09-27 08:40 +0200

csiph-web