Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1740265
| From | Ulf Hansson <ulf.hansson@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 02/12] arm64: dts: mt8173: remove "mediatek,mt8135-mmc" from mmc nodes |
| Date | 2017-09-27 00:40 +0200 |
| Message-ID | <uu6Ge-2hx-31@gated-at.bofh.it> (permalink) |
| References | <uoPmF-7Mg-11@gated-at.bofh.it> <uoPwl-7PF-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 12 September 2017 at 11:07, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
> devicetree bindings has been updated to support multi-platforms,
> so that each platform has its owns compatible name.
> And, this compatible name may used in driver to distinguish with
> other platform.
This does not seems to be DT backwards compatible.
If the driver starts interpreting the "mt8135-mmc" differently,
wouldn't that lead to old DTBs to become broken?
Kind regards
Uffe
>
> Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index b99a273..26396ef 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -682,8 +682,7 @@
> };
>
> mmc0: mmc@11230000 {
> - compatible = "mediatek,mt8173-mmc",
> - "mediatek,mt8135-mmc";
> + compatible = "mediatek,mt8173-mmc";
> reg = <0 0x11230000 0 0x1000>;
> interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_LOW>;
> clocks = <&pericfg CLK_PERI_MSDC30_0>,
> @@ -693,8 +692,7 @@
> };
>
> mmc1: mmc@11240000 {
> - compatible = "mediatek,mt8173-mmc",
> - "mediatek,mt8135-mmc";
> + compatible = "mediatek,mt8173-mmc";
> reg = <0 0x11240000 0 0x1000>;
> interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_LOW>;
> clocks = <&pericfg CLK_PERI_MSDC30_1>,
> @@ -704,8 +702,7 @@
> };
>
> mmc2: mmc@11250000 {
> - compatible = "mediatek,mt8173-mmc",
> - "mediatek,mt8135-mmc";
> + compatible = "mediatek,mt8173-mmc";
> reg = <0 0x11250000 0 0x1000>;
> interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_LOW>;
> clocks = <&pericfg CLK_PERI_MSDC30_2>,
> @@ -715,8 +712,7 @@
> };
>
> mmc3: mmc@11260000 {
> - compatible = "mediatek,mt8173-mmc",
> - "mediatek,mt8135-mmc";
> + compatible = "mediatek,mt8173-mmc";
> reg = <0 0x11260000 0 0x1000>;
> interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_LOW>;
> clocks = <&pericfg CLK_PERI_MSDC30_3>,
> --
> 1.8.1.1.dirty
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
mmc: mediatek: add support of mt2701/mt2712 Chaotian Jing <chaotian.jing@mediatek.com> - 2017-09-12 11:20 +0200
[PATCH 10/12] mmc: mediatek: add latch-ck support Chaotian Jing <chaotian.jing@mediatek.com> - 2017-09-12 11:20 +0200
[PATCH 02/12] arm64: dts: mt8173: remove "mediatek,mt8135-mmc" from mmc nodes Chaotian Jing <chaotian.jing@mediatek.com> - 2017-09-12 11:20 +0200
Re: [PATCH 02/12] arm64: dts: mt8173: remove "mediatek,mt8135-mmc" from mmc nodes Ulf Hansson <ulf.hansson@linaro.org> - 2017-09-27 00:40 +0200
Re: [PATCH 02/12] arm64: dts: mt8173: remove "mediatek,mt8135-mmc" from mmc nodes Chaotian Jing <chaotian.jing@mediatek.com> - 2017-09-27 03:20 +0200
[PATCH 04/12] mmc: mediatek: make hs400_tune_response only for mt8173 Chaotian Jing <chaotian.jing@mediatek.com> - 2017-09-12 11:20 +0200
[PATCH 05/12] mmc: mediatek: add pad_tune0 support Chaotian Jing <chaotian.jing@mediatek.com> - 2017-09-12 11:20 +0200
[PATCH 07/12] mmc: mediatek: add busy_check support Chaotian Jing <chaotian.jing@mediatek.com> - 2017-09-12 11:20 +0200
[PATCH 06/12] mmc: mediatek: add async fifo and data tune support Chaotian Jing <chaotian.jing@mediatek.com> - 2017-09-12 11:20 +0200
csiph-web