Re: [PATCH v6 2/2] tracing: Add support for preempt and irq enable/disable events

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 2/2] tracing: Add support for preempt and irq enable/disable events
Date	2017-09-25 13:00 +0200
Message-ID	<utzhg-5f9-13@gated-at.bofh.it> (permalink)
References	(2 earlier) <uss8b-4hz-43@gated-at.bofh.it> <usAS5-ZW-15@gated-at.bofh.it> <utx5M-3Sb-5@gated-at.bofh.it> <utyEx-4YG-3@gated-at.bofh.it> <utyXV-55N-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 25 Sep 2017 12:32:23 +0200
Peter Zijlstra <peterz@infradead.org> wrote:


> > You mean you want to trace all calls to preempt and irq off even if
> > preempt and irqs are already off?  
> 
> Sure, why not? This stuff naturally nests, and who is to say its not a
> useful thing to trace all of them?
> 
> By also tracing the nested sections you can, for instance, see how much
> you'd really win by getting rid of the outer one. If, for instance, the
> outer only accounts for 1% of the time, while the inner ones are
> interlinked and span the other 99%, there's more work to do than if that
> were not the case.

If we do this we need a field to record if the preemption or irqs were
toggled by that call. Something that filters could easily be added to
only show what this patch set has.

-- Steve

Thread

[PATCH v6 2/2] tracing: Add support for preempt and irq enable/disable events Joel Fernandes <joelaf@google.com> - 2017-09-22 04:00 +0200
  Re: [PATCH v6 2/2] tracing: Add support for preempt and irq  enable/disable events Peter Zijlstra <peterz@infradead.org> - 2017-09-22 11:10 +0200
    Re: [PATCH v6 2/2] tracing: Add support for preempt and irq  enable/disable events Joel Fernandes <joelaf@google.com> - 2017-09-22 20:30 +0200
      Re: [PATCH v6 2/2] tracing: Add support for preempt and irq  enable/disable events Peter Zijlstra <peterz@infradead.org> - 2017-09-25 10:40 +0200
        Re: [PATCH v6 2/2] tracing: Add support for preempt and irq  enable/disable events Steven Rostedt <rostedt@goodmis.org> - 2017-09-25 12:20 +0200
          Re: [PATCH v6 2/2] tracing: Add support for preempt and irq  enable/disable events Peter Zijlstra <peterz@infradead.org> - 2017-09-25 12:40 +0200
            Re: [PATCH v6 2/2] tracing: Add support for preempt and irq  enable/disable events Steven Rostedt <rostedt@goodmis.org> - 2017-09-25 13:00 +0200
              Re: [PATCH v6 2/2] tracing: Add support for preempt and irq  enable/disable events Joel Fernandes <joelaf@google.com> - 2017-09-26 01:00 +0200
                Re: [PATCH v6 2/2] tracing: Add support for preempt and irq  enable/disable events Steven Rostedt <rostedt@goodmis.org> - 2017-09-26 04:50 +0200
        Re: [PATCH v6 2/2] tracing: Add support for preempt and irq  enable/disable events Joel Fernandes <joelaf@google.com> - 2017-09-26 02:30 +0200

csiph-web