Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1738137

Re: [PATCH 1/6] [media] omap_vout: Delete an error message for a failed memory allocation in omap_vout_create_video_devices()

From Joe Perches <joe@perches.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/6] [media] omap_vout: Delete an error message for a failed memory allocation in omap_vout_create_video_devices()
Date 2017-09-24 12:40 +0200
Message-ID <utcul-7yW-11@gated-at.bofh.it> (permalink)
References <utckF-7vc-9@gated-at.bofh.it> <utckG-7vc-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sun, 2017-09-24 at 12:22 +0200, SF Markus Elfring wrote:
> Omit an extra message for a memory allocation failure in this function.
[]
> diff --git a/drivers/media/platform/omap/omap_vout.c b/drivers/media/platform/omap/omap_vout.c
[]
> @@ -1948,7 +1948,5 @@ static int __init omap_vout_create_video_devices(struct platform_device *pdev)
> -		if (!vout) {
> -			dev_err(&pdev->dev, ": could not allocate memory\n");
> +		if (!vout)
>  			return -ENOMEM;
> -		}
>  
>  		vout->vid = k;
>  		vid_dev->vouts[k] = vout;

Use normal patch styles.
Fix your tools before you send any more patches.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/6] [media] omap_vout: Adjustments for three function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-24 12:30 +0200
  [PATCH 1/6] [media] omap_vout: Delete an error message for a failed  memory allocation in omap_vout_create_video_devices() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-24 12:30 +0200
    Re: [PATCH 1/6] [media] omap_vout: Delete an error message for a  failed memory allocation in omap_vout_create_video_devices() Joe Perches <joe@perches.com> - 2017-09-24 12:40 +0200
  [PATCH 3/6] [media] omap_vout: Adjust a null pointer check in two  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-24 12:30 +0200
  [PATCH 2/6] [media] omap_vout: Improve a size determination in two  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-24 12:30 +0200
  [PATCH 6/6] [media] omap_vout: Delete two unnecessary variable  initialisations in omap_vout_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-24 12:40 +0200
  [PATCH 5/6] [media] omap_vout: Delete an unnecessary variable  initialisation in omap_vout_open() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-24 12:40 +0200

csiph-web