[PATCH 3/6] [media] omap_vout: Adjust a null pointer check in two functions

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH 3/6] [media] omap_vout: Adjust a null pointer check in two functions
Date	2017-09-24 12:30 +0200
Message-ID	<utckF-7vc-7@gated-at.bofh.it> (permalink)
References	<utckF-7vc-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 24 Sep 2017 10:30:29 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The script “checkpatch.pl” pointed information out like the following.

Comparison to NULL could be written !…

Thus fix the affected source code places.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/media/platform/omap/omap_vout.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/omap/omap_vout.c b/drivers/media/platform/omap/omap_vout.c
index 4a4d171ca573..2b55a8ebd1ad 100644
--- a/drivers/media/platform/omap/omap_vout.c
+++ b/drivers/media/platform/omap/omap_vout.c
@@ -1006,7 +1006,7 @@ static int omap_vout_open(struct file *file)
 	vout = video_drvdata(file);
 	v4l2_dbg(1, debug, &vout->vid_dev->v4l2_dev, "Entering %s\n", __func__);
 
-	if (vout == NULL)
+	if (!vout)
 		return -ENODEV;
 
 	/* for now, we only support single open */
@@ -2095,7 +2095,7 @@ static int __init omap_vout_probe(struct platform_device *pdev)
 	}
 
 	vid_dev = kzalloc(sizeof(*vid_dev), GFP_KERNEL);
-	if (vid_dev == NULL) {
+	if (!vid_dev) {
 		ret = -ENOMEM;
 		goto err_dss_init;
 	}
-- 
2.14.1

Thread

[PATCH 0/6] [media] omap_vout: Adjustments for three function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-24 12:30 +0200
  [PATCH 1/6] [media] omap_vout: Delete an error message for a failed  memory allocation in omap_vout_create_video_devices() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-24 12:30 +0200
    Re: [PATCH 1/6] [media] omap_vout: Delete an error message for a  failed memory allocation in omap_vout_create_video_devices() Joe Perches <joe@perches.com> - 2017-09-24 12:40 +0200
  [PATCH 3/6] [media] omap_vout: Adjust a null pointer check in two  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-24 12:30 +0200
  [PATCH 2/6] [media] omap_vout: Improve a size determination in two  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-24 12:30 +0200
  [PATCH 6/6] [media] omap_vout: Delete two unnecessary variable  initialisations in omap_vout_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-24 12:40 +0200
  [PATCH 5/6] [media] omap_vout: Delete an unnecessary variable  initialisation in omap_vout_open() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-24 12:40 +0200

csiph-web