[PATCH 2/2] [media] dmxdev: Improve a size determination in dvb_dmxdev_add_pid()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] [media] dmxdev: Improve a size determination in dvb_dmxdev_add_pid()
Date	2017-09-26 15:40 +0200
Message-ID	<utYfE-5n5-21@gated-at.bofh.it> (permalink)
References	<utYfD-5n5-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 26 Sep 2017 15:22:57 +0200

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/media/dvb-core/dmxdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/dvb-core/dmxdev.c b/drivers/media/dvb-core/dmxdev.c
index f8bf7459d5ca..8e0f91775fe4 100644
--- a/drivers/media/dvb-core/dmxdev.c
+++ b/drivers/media/dvb-core/dmxdev.c
@@ -809,7 +809,7 @@ static int dvb_dmxdev_add_pid(struct dmxdev *dmxdev,
 	    (!list_empty(&filter->feed.ts)))
 		return -EINVAL;
 
-	feed = kzalloc(sizeof(struct dmxdev_feed), GFP_KERNEL);
+	feed = kzalloc(sizeof(*feed), GFP_KERNEL);
 	if (feed == NULL)
 		return -ENOMEM;
 
-- 
2.14.1

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] [media] dmxdev: Fine-tuning for two function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-26 15:40 +0200
  [PATCH 1/2] [media] dmxdev: Use common error handling code in  dvb_dmxdev_start_feed() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-26 15:40 +0200
  [PATCH 2/2] [media] dmxdev: Improve a size determination in  dvb_dmxdev_add_pid() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-26 15:40 +0200

csiph-web