Re: [PATCH v3] mm: introduce validity check on vm dirtiness settings

From	Jan Kara <jack@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] mm: introduce validity check on vm dirtiness settings
Date	2017-09-26 15:40 +0200
Message-ID	<utYfE-5n5-19@gated-at.bofh.it> (permalink)
References	(1 earlier) <utVhM-3uw-27@gated-at.bofh.it> <utVUu-3YA-7@gated-at.bofh.it> <utWdR-46A-21@gated-at.bofh.it> <utWxc-4fP-13@gated-at.bofh.it> <utWGR-4jM-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue 26-09-17 13:54:23, Michal Hocko wrote:
> On Tue 26-09-17 19:45:45, Yafang Shao wrote:
> > >> > To be honest I am not entirely sure this is worth the code and the
> > >> > future maintenance burden.
> > >> I'm not sure if this code is a burden for the future maintenance, but
> > >> I think that if we don't introduce this code it is a burden to the
> > >> admins.
> > >
> > > anytime we might need to tweak background vs direct limit we would have
> > > to change these checks as well and that sounds like a maint. burden to
> > > me.
> > 
> > Would pls. show me some example ?
> 
> What kind of examples would you like to see. I meant that if the current
> logic of bacground vs. direct limit changes the code to check it which
> is at a different place IIRC would have to be kept in sync.
> 
> That being said, this is my personal opinion, I will not object if there
> is a general consensus on merging this. I just believe that this is not
> simply worth adding a single line of code. You can then a lot of harm by
> setting different values which would pass the added check.

So I personally think that the checks Yafang added are worth the extra
code. The situation with ratio/bytes interface and hard/background limit is
complex enough that it makes sense to have basic sanity checks to me. That
being said I don't have too strong opinion on this so just documentation
update would be also fine by me.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] mm: introduce validity check on vm dirtiness settings Yafang Shao <laoar.shao@gmail.com> - 2017-09-19 17:00 +0200
  Re: [PATCH v3] mm: introduce validity check on vm dirtiness settings Michal Hocko <mhocko@kernel.org> - 2017-09-26 12:30 +0200
    Re: [PATCH v3] mm: introduce validity check on vm dirtiness settings Yafang Shao <laoar.shao@gmail.com> - 2017-09-26 13:10 +0200
      Re: [PATCH v3] mm: introduce validity check on vm dirtiness settings Michal Hocko <mhocko@kernel.org> - 2017-09-26 13:30 +0200
        Re: [PATCH v3] mm: introduce validity check on vm dirtiness settings Yafang Shao <laoar.shao@gmail.com> - 2017-09-26 13:50 +0200
          Re: [PATCH v3] mm: introduce validity check on vm dirtiness settings Michal Hocko <mhocko@kernel.org> - 2017-09-26 14:00 +0200
            Re: [PATCH v3] mm: introduce validity check on vm dirtiness settings Jan Kara <jack@suse.cz> - 2017-09-26 15:40 +0200

csiph-web