Re: [PATCH] cgroup: Reinit cgroup_taskset structure before cgroup_migrate_execute() returns

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cgroup: Reinit cgroup_taskset structure before cgroup_migrate_execute() returns
Date	2017-09-22 17:20 +0200
Message-ID	<usxUe-7El-3@gated-at.bofh.it> (permalink)
References	<usabg-1IE-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Sep 21, 2017 at 09:54:13AM -0400, Waiman Long wrote:
...
> To allow reuse of the cgroup_mgctx structure, some fields in that
> structure are now re-initialized at the end of cgroup_migrate_execute()
> function call so that the structure can be reused again in a later
> iteration without causing problem.
> 
> This bug was introduced in the commit e595cd706982 ("group: track
> migration context in cgroup_mgctx") in 4.11. This commit moves the
> cgroup_taskset initialization out of cgroup_migrate(). The commit
> 10467270fb3 ("cgroup: don't call migration methods if there are no
> tasks to migrate") helped, but did not completely resolve the problem.
> 
> Fixes: e595cd706982bff0211e6fafe5a108421e747fbc ("group: track migration context in cgroup_mgctx")
> Signed-off-by: Waiman Long <longman@redhat.com>

Applied to cgroup/for-4.14-fixes.

Thanks, Waiman!

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cgroup: Reinit cgroup_taskset structure before cgroup_migrate_execute() returns Waiman Long <longman@redhat.com> - 2017-09-21 16:00 +0200
  Re: [PATCH] cgroup: Reinit cgroup_taskset structure before  cgroup_migrate_execute() returns Tejun Heo <tj@kernel.org> - 2017-09-22 17:20 +0200

csiph-web