Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1737574

Re: [PATCH v5] iio: dac: ds4422/ds4424 dac driver

Show all headers | View raw

On Thu, 21 Sep 2017 18:26:59 -0500
Rob Herring <robh@kernel.org> wrote:

> On Tue, Sep 19, 2017 at 12:23:32AM -0700, Ismail Kose wrote:
> > From: "Ismail H. Kose" <ihkose@gmail.com>
> > 
> > This patch provides an iio device driver for DS4422/DS4424 chips that support
> > two/four channel 7-bit Sink/Source Current DAC.
> > 
> > Signed-off-by: Ismail Kose <Ismail.Kose@maximintegrated.com>

Just a quick one before V6.  Please don't reply to a previous version
when sending a new version.  It leads to very deep and confusing thread
structures.

Just start a new thread.

Jonathan
> > ---
> > v5:
> > 	* Removed unused variable
> > v4:
> > 	* Removed unnecessary code and space optimization
> > 	* Alphabetic order in Kcobfig and Makefile
> > v3:
> > 	* Removed iio-map and platform file support
> > 	* Removed ds4424.h file
> > 	* Fixed ADC value read bug
> > 	* Removed confused comments
> > 	* Added device tree binding file
> > 	* Fixed bugs in probe and read function
> > 
> > v2:
> > 	* Fixed coding style and removed unncessary code
> > 	* Removed min/max rfs, ifs-scale, etc values from device tree
> > 	* Removed unused code, definitions and some comments
> > 	* Removed regulator control and made standard structure
> > 	* Removed data processing and channel scale
> > 	* Removed device tree binding file
> > 
> >  .../devicetree/bindings/iio/dac/ds4424.txt         |  20 ++  
> 
> It's preferred to split bindings to separate patch.
> 
> >  drivers/iio/dac/Kconfig                            |   9 +
> >  drivers/iio/dac/Makefile                           |   1 +
> >  drivers/iio/dac/ds4424.c                           | 394 +++++++++++++++++++++
> >  4 files changed, 424 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/iio/dac/ds4424.txt
> >  create mode 100644 drivers/iio/dac/ds4424.c
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/dac/ds4424.txt b/Documentation/devicetree/bindings/iio/dac/ds4424.txt
> > new file mode 100644
> > index 000000000000..840b11e1d813
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/dac/ds4424.txt
> > @@ -0,0 +1,20 @@
> > +Maxim Integrated DS4422/DS4424 7-bit Sink/Source Current DAC Device Driver
> > +
> > +Datasheet publicly available at:
> > +https://datasheets.maximintegrated.com/en/ds/DS4422-DS4424.pdf
> > +
> > +Required properties:
> > +	- compatible: Must be "maxim,ds4422" or "maxim,ds4424"  
> 
> One compatible per line please.
> 
> > +	- reg: Should contain the DAC I2C address
> > +	- maxim,rfs-resistors-ohms: Should contain reference resistor  
> 
> ...reference resistor ohms
> 
> > +
> > +Optional properties:
> > +	- vcc-supply: Power supply is optional. If not defined, driver will ignore it.
> > +
> > +Example:
> > +	ds4224@10 {
> > +		compatible = "maxim,ds4424";
> > +		reg = <0x10>; /* When A0, A1 pins are ground */
> > +		vcc-supply = "dac_vcc_3v3";  
> 
> This is not how the regulator binding works.
> 
> > +		maxim,rfs-resistors-ohms = <400 800 1000 1600>;  
> 
> The description needs to explain this is 4 values.
> 
> > +	};  
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3] iio: dac: ds4422/ds4424 dac driver Peter Meerwald-Stadler <pmeerw@pmeerw.net> - 2017-09-19 06:50 +0200
  RE: [PATCH v3] iio: dac: ds4422/ds4424 dac driver Ismail Kose <Ismail.Kose@maximintegrated.com> - 2017-09-19 08:30 +0200
    Re: [PATCH v5] iio: dac: ds4422/ds4424 dac driver Rob Herring <robh@kernel.org> - 2017-09-22 01:30 +0200
      Re: [PATCH v5] iio: dac: ds4422/ds4424 dac driver Jonathan Cameron <Jonathan.Cameron@huawei.com> - 2017-09-22 17:20 +0200

csiph-web