Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1737525

Re: [PATCH 2/4] Makes all those related functions receive the FILE pointer

Show all headers | View raw

Em Fri, Sep 22, 2017 at 11:03:19AM +0200, Jiri Olsa escreveu:
> On Mon, Sep 18, 2017 at 01:55:20PM +0800, yuzhoujian wrote:
> > Signed-off-by: yuzhoujian <yuzhoujian@didichuxing.com>
> > +++ b/tools/perf/builtin-script.c
> > @@ -486,8 +486,8 @@ static int perf_session__check_output_opt(struct perf_session *session)
> >  	return 0;
> >  }
> >  
> > -static void print_sample_iregs(struct perf_sample *sample,
> > -			  struct perf_event_attr *attr)
> > +static void fprint_sample_iregs(struct perf_sample *sample,
> > +			  struct perf_event_attr *attr, FILE *fp)
> 
> please make sure the perf gets compiled after every change,
> I think this will break compile because of unused *fp,
> use the __maybe_unused attribute

Yes, that will save me some time, as I _will_ do this. Doing it
judiciously will make me want to review and process your patches faster
in the future, BTW.

To know why this is important, please read about 'git bisect'.

- Arnaldo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/4] Makes all those related functions receive the FILE pointer yuzhoujian <ufo19890607@gmail.com> - 2017-09-18 08:00 +0200
  Re: [PATCH 2/4] Makes all those related functions receive the FILE  pointer Jiri Olsa <jolsa@redhat.com> - 2017-09-22 11:10 +0200
    Re: [PATCH 2/4] Makes all those related functions receive the FILE  pointer Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-22 16:20 +0200
  Re: [PATCH 2/4] Makes all those related functions receive the FILE  pointer Jiri Olsa <jolsa@redhat.com> - 2017-09-22 11:10 +0200
    Re: [PATCH 2/4] Makes all those related functions receive the FILE  pointer Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-22 16:20 +0200

csiph-web