Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1737299

Re: [PATCH 2/4] Makes all those related functions receive the FILE pointer

Show all headers | View raw

On Mon, Sep 18, 2017 at 01:55:20PM +0800, yuzhoujian wrote:
> Signed-off-by: yuzhoujian <yuzhoujian@didichuxing.com>
> ---
>  tools/perf/builtin-script.c | 247 ++++++++++++++++++++++++--------------------
>  1 file changed, 136 insertions(+), 111 deletions(-)
> 
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 91b5225..f709f6f 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -486,8 +486,8 @@ static int perf_session__check_output_opt(struct perf_session *session)
>  	return 0;
>  }
>  
> -static void print_sample_iregs(struct perf_sample *sample,
> -			  struct perf_event_attr *attr)
> +static void fprint_sample_iregs(struct perf_sample *sample,
> +			  struct perf_event_attr *attr, FILE *fp)

please make sure the perf gets compiled after every change,
I think this will break compile because of unused *fp,
use the __maybe_unused attribute

jirka

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/4] Makes all those related functions receive the FILE pointer yuzhoujian <ufo19890607@gmail.com> - 2017-09-18 08:00 +0200
  Re: [PATCH 2/4] Makes all those related functions receive the FILE  pointer Jiri Olsa <jolsa@redhat.com> - 2017-09-22 11:10 +0200
    Re: [PATCH 2/4] Makes all those related functions receive the FILE  pointer Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-22 16:20 +0200
  Re: [PATCH 2/4] Makes all those related functions receive the FILE  pointer Jiri Olsa <jolsa@redhat.com> - 2017-09-22 11:10 +0200
    Re: [PATCH 2/4] Makes all those related functions receive the FILE  pointer Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-22 16:20 +0200

csiph-web