Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1737259

Re: [PATCH 0/4] iirqchip: Handle return value of kasprintf

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Marc Zyngier <marc.zyngier@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH 0/4] iirqchip: Handle return value of kasprintf
Date Fri, 22 Sep 2017 10:20:02 +0200
Message-ID <usrlM-3MM-7@gated-at.bofh.it> (permalink)
References <urIf0-kT-5@gated-at.bofh.it>
X-Original-To Arvind Yadav <arvind.yadav.cs@gmail.com>
Organization ARM Ltd
User-Agent Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
MIME-Version 1.0
Content-Type text/plain
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 15
X-Original-Cc tglx@linutronix.de, jason@lakedaemon.net, vz@mleia.com, slemieux.tyco@gmail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
X-Original-Date Fri, 22 Sep 2017 09:10:41 +0100
X-Original-Message-ID <86vakbnofy.fsf@arm.com>
X-Original-References <1505894901-9403-1-git-send-email-arvind.yadav.cs@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1737259

Show key headers only | View raw


On Wed, Sep 20 2017 at  1:38:18 pm BST, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> kasprintf() can fail here and we must check its return value.

Or not. The use of these strings is purely cosmetic (they are only used
to display various debug information), and printk is perfectly able to
handle a NULL string.

Refusing to probe an essential piece of HW because a debug feature
failed seems at best counter-productive.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/4] iirqchip: Handle return value of kasprintf Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-20 10:10 +0200
  [PATCH 3/4] irqchip/gic: Handle return value of kasprintf Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-20 10:10 +0200
  [PATCH 1/4] irqchip/gic-v3-its: Handle return value of kasprintf Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-20 10:10 +0200
  [PATCH 2/4] irqchip/gic-v3-its-platform-msi: Handle return value of kasprintf Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-20 10:10 +0200
  Re: [PATCH 0/4] iirqchip: Handle return value of kasprintf Marc Zyngier <marc.zyngier@arm.com> - 2017-09-22 10:20 +0200
    Re: [PATCH 0/4] iirqchip: Handle return value of kasprintf Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-22 11:00 +0200

csiph-web