Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1737259

Re: [PATCH 0/4] iirqchip: Handle return value of kasprintf

From Marc Zyngier <marc.zyngier@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH 0/4] iirqchip: Handle return value of kasprintf
Date 2017-09-22 10:20 +0200
Message-ID <usrlM-3MM-7@gated-at.bofh.it> (permalink)
References <urIf0-kT-5@gated-at.bofh.it>
Organization ARM Ltd

Show all headers | View raw

On Wed, Sep 20 2017 at  1:38:18 pm BST, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> kasprintf() can fail here and we must check its return value.

Or not. The use of these strings is purely cosmetic (they are only used
to display various debug information), and printk is perfectly able to
handle a NULL string.

Refusing to probe an essential piece of HW because a debug feature
failed seems at best counter-productive.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] iirqchip: Handle return value of kasprintf Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-20 10:10 +0200
  [PATCH 3/4] irqchip/gic: Handle return value of kasprintf Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-20 10:10 +0200
  [PATCH 1/4] irqchip/gic-v3-its: Handle return value of kasprintf Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-20 10:10 +0200
  [PATCH 2/4] irqchip/gic-v3-its-platform-msi: Handle return value of kasprintf Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-20 10:10 +0200
  Re: [PATCH 0/4] iirqchip: Handle return value of kasprintf Marc Zyngier <marc.zyngier@arm.com> - 2017-09-22 10:20 +0200
    Re: [PATCH 0/4] iirqchip: Handle return value of kasprintf Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-22 11:00 +0200

csiph-web