Re: [PATCH] HID: core: assign usbhid to handle EETI PID=0x0001 HID device

From	Boszormenyi Zoltan <zboszor@pr.hu>
Newsgroups	linux.kernel
Subject	Re: [PATCH] HID: core: assign usbhid to handle EETI PID=0x0001 HID device
Date	2017-09-22 11:00 +0200
Message-ID	<usrYu-3Z9-15@gated-at.bofh.it> (permalink)
References	<udcRI-GO-5@gated-at.bofh.it> <uhdPc-qO-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 2017-08-22 11:33, Benjamin Tissoires wrote:
> On Aug 11 2017 or thereabouts, JamChen wrote:
>> From: Jam Chen <jam.chen.egalax@gmail.com>
>>
>> The vendor used the same PID(0x0001) for multiple touch IC controllers.
>> The newer ICs can support HID class and report the multitouch collection
>> in the descriptor. So they were handled by the hid-multitouch driver.
>> But some customized firmwares don't support multitouch protocol even if
>> driver have got the Win8 blob data.
>>
>> Actually, those ICs only support the single touch function, and report
>> the mouse protocol by default. We can assign usbhid to handle them all.
>>
>> Signed-off-by: Jam Chen <jam.chen.egalax@gmail.com>
>> ---
> 
> Him
> 
> FYI, I'd rather see a full working solution such as the one presented here:
> https://patchwork.kernel.org/patch/9876649/
> 
> Because this solution is half working as it regresses on some devices
> while solving others.
> 
> Cheers,
> Benjamin

is there any news about resolving this issue in the upstream kernel?

Thanks in advance,
Zoltán Böszörményi

> 
>>   drivers/hid/hid-core.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
>> index 9017dcc14502..df4696022488 100644
>> --- a/drivers/hid/hid-core.c
>> +++ b/drivers/hid/hid-core.c
>> @@ -828,6 +828,10 @@ static int hid_scan_report(struct hid_device *hid)
>>   				 */
>>   				hid->group = HID_GROUP_RMI;
>>   		break;
>> +	case USB_VENDOR_ID_DWAV:
>> +		if (hid->product == USB_DEVICE_ID_EGALAX_TOUCHCONTROLLER)
>> +			hid->group = HID_GROUP_GENERIC;
>> +		break;
>>   	}
>>   
>>   	/* fall back to generic driver in case specific driver doesn't exist */
>> -- 
>> 2.11.0
>>
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] HID: core: assign usbhid to handle EETI PID=0x0001 HID  device Boszormenyi Zoltan <zboszor@pr.hu> - 2017-09-22 11:00 +0200

csiph-web