Re: [PATCH v2] iommu/of: Remove PCI host bridge node check

From	Joerg Roedel <joro@8bytes.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] iommu/of: Remove PCI host bridge node check
Date	2017-09-22 11:00 +0200
Message-ID	<usrYu-3Z9-11@gated-at.bofh.it> (permalink)
References	<us6Km-7Zx-7@gated-at.bofh.it> <us6U2-83f-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hey Robin,

On Thu, Sep 21, 2017 at 11:20:58AM +0100, Robin Murphy wrote:
> of_pci_iommu_init() tries to be clever and stop its alias walk at the
> device represented by master_np, in case of weird PCI topologies where
> the bridge to the IOMMU and the rest of the system is not at the root.
> It turns out this is a bit short-sighted, since there are plenty of
> other callers of pci_for_each_dma_alias() which would also need the same
> behaviour in that situation, and the only platform so far with such a
> topology (Cavium ThunderX2) already solves it more generally via a PCI
> quirk. As this check is effectively redundant, and returning a boolean
> value as an int is a bit broken anyway, let's just get rid of it.
> 
> Reported-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>

Can you send me a Fixes: tag for this please? No need to resend the
whole patch, I just need the tag.

Thanks,

	Joerg

Thread

[PATCH] iommu/of: Remove PCI host bridge node check Robin Murphy <robin.murphy@arm.com> - 2017-09-21 12:20 +0200
  [PATCH v2] iommu/of: Remove PCI host bridge node check Robin Murphy <robin.murphy@arm.com> - 2017-09-21 12:30 +0200
    Re: [PATCH v2] iommu/of: Remove PCI host bridge node check Jean-Philippe Brucker <jean-philippe.brucker@arm.com> - 2017-09-21 13:10 +0200
    Re: [PATCH v2] iommu/of: Remove PCI host bridge node check Joerg Roedel <joro@8bytes.org> - 2017-09-22 11:00 +0200
      Re: [PATCH v2] iommu/of: Remove PCI host bridge node check Robin Murphy <robin.murphy@arm.com> - 2017-09-22 12:00 +0200
        Re: [PATCH v2] iommu/of: Remove PCI host bridge node check Joerg Roedel <joro@8bytes.org> - 2017-09-22 12:10 +0200

csiph-web