Re: [PATCH] block: drop "sending ioctl to a partition" message

From	Christoph Hellwig <hch@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] block: drop "sending ioctl to a partition" message
Date	2017-09-21 17:00 +0200
Message-ID	<usb7j-2jN-9@gated-at.bofh.it> (permalink)
References	<usaXD-2gx-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

This looks ok to me, but do we even need to keep the special
cases above?  Is there anything relying on the safe but not very
useful ioctls?

Condensing the thing down to:

int scsi_verify_blk_ioctl(struct block_device *bd, unsigned int cmd)
{
	if (bd && bd == bd->bd_contains)
		return 0;
	if (capable(CAP_SYS_RAWIO))
		return 0;
	return -ENOIOCTLCMD;
}

would certainly be nice.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] block: drop "sending ioctl to a partition" message Paolo Bonzini <pbonzini@redhat.com> - 2017-09-21 16:50 +0200
  Re: [PATCH] block: drop "sending ioctl to a partition" message Paolo Bonzini <pbonzini@redhat.com> - 2017-09-21 17:00 +0200
  Re: [PATCH] block: drop "sending ioctl to a partition" message Christoph Hellwig <hch@infradead.org> - 2017-09-21 17:00 +0200

csiph-web