Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1736735
| From | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] block: drop "sending ioctl to a partition" message |
| Date | 2017-09-21 17:00 +0200 |
| Message-ID | <usb7j-2jN-7@gated-at.bofh.it> (permalink) |
| References | <usaXD-2gx-7@gated-at.bofh.it> <usb7j-2jN-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 21/09/2017 16:53, Christoph Hellwig wrote:
> This looks ok to me, but do we even need to keep the special
> cases above? Is there anything relying on the safe but not very
> useful ioctls?
No idea, I stuck to the usual "don't break userspace" rule.
Honestly I doubt anything is using most of those ioctls _in general_,
not just on a partition.
Paolo
> Condensing the thing down to:
>
> int scsi_verify_blk_ioctl(struct block_device *bd, unsigned int cmd)
> {
> if (bd && bd == bd->bd_contains)
> return 0;
> if (capable(CAP_SYS_RAWIO))
> return 0;
> return -ENOIOCTLCMD;
> }
>
> would certainly be nice.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] block: drop "sending ioctl to a partition" message Paolo Bonzini <pbonzini@redhat.com> - 2017-09-21 16:50 +0200 Re: [PATCH] block: drop "sending ioctl to a partition" message Paolo Bonzini <pbonzini@redhat.com> - 2017-09-21 17:00 +0200 Re: [PATCH] block: drop "sending ioctl to a partition" message Christoph Hellwig <hch@infradead.org> - 2017-09-21 17:00 +0200
csiph-web