Re: [media] spca500: Use common error handling code in spca500_synch310()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	Re: [media] spca500: Use common error handling code in spca500_synch310()
Date	2017-09-22 22:50 +0200
Message-ID	<usD3A-2i1-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <uszCG-kW-5@gated-at.bofh.it> <usAfn-xX-5@gated-at.bofh.it> <usAfn-xX-9@gated-at.bofh.it> <usAfn-xX-7@gated-at.bofh.it> <usB1M-13h-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> No one needs to argue about keeping it the way it is.

I got an other impression in this case after a bit of information
was presented which seems to be contradictory.


> I don't see any improvement brought by the proposed change,

Do you care if the source code for an error message is present only once
in this function?


> other than making the code harder to read.

I suggest to reconsider this concern.


> I find goto statements hard to read, because they inherently make some
> information non local.  They are justified in error path handling,
> if the error path only unwinds what the function did early on.
> That's not the case here.

I am looking also for change possibilities without such a restriction.

 
> The same applies to dozens of patches you proposed recently.

I proposed some software updates to reduce a bit of code duplication.

Do you find any corresponding approaches useful?

Regards,
Markus

Thread

[PATCH] [media] spca500: Use common error handling code in  spca500_synch310() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-22 19:10 +0200
  Re: [PATCH] [media] spca500: Use common error handling code in  spca500_synch310() Julia Lawall <julia.lawall@lip6.fr> - 2017-09-22 19:10 +0200
    Re: [media] spca500: Use common error handling code in  spca500_synch310() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-22 19:50 +0200
      Re: [media] spca500: Use common error handling code in  spca500_synch310() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-22 19:50 +0200
        Re: [media] spca500: Use common error handling code in  spca500_synch310() Daniele Nicolodi <daniele@grinta.net> - 2017-09-22 20:40 +0200
          Re: [media] spca500: Use common error handling code in  spca500_synch310() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-22 22:50 +0200
        Re: [media] spca500: Use common error handling code in  spca500_synch310() Joe Perches <joe@perches.com> - 2017-09-22 20:40 +0200
      Re: [media] spca500: Use common error handling code in  spca500_synch310() Julia Lawall <julia.lawall@lip6.fr> - 2017-09-22 19:50 +0200

csiph-web